Prevent waiting for diagnositcs (#21)

* Add VerdictStatus data.

* Remove VerdictPE.
See https://codeforces.com/blog/entry/1028 for details.

* Minor code cleanups.

Author: infalmo

codeforces/submissions.go

@@ -2,6 +2,7 @@ package codeforces
 
 import (
 	"fmt"
+	"strings"
 	"time"
 
 	"github.com/PuerkitoBio/goquery"
@@ -11,19 +12,37 @@ import (
 type (
 	// Submission holds submission data.
 	Submission struct {
-		ID        string
-		When      time.Time
-		Who       string
-		Problem   string
-		Language  string
-		Verdict   string
-		Time      string
-		Memory    string
-		IsJudging bool
-		Arg       Args
+		ID            string
+		When          time.Time
+		Who           string
+		Problem       string
+		Language      string
+		Verdict       string
+		VerdictStatus int
+		Time          string
+		Memory        string
+		IsJudging     bool
+		Arg           Args
 	}
 )
 
+// Submissions verdict status.
+const (
+	VerdictAC = 1 // Accepted
+
+	VerdictWA  = 2 // Wrong Answer
+	VerdictRTE = 4 // Run Time Error
+
+	VerdictCE  = 5 // Compilation Error
+	VerdictTLE = 6 // Time Limit Exceeded
+	VerdictMLE = 7 // Memory Limit Exceeded
+	VerdictILE = 8 // Idleness Limit Exceeded
+
+	VerdictDOJ  = 9  // Denial Of Judgement
+	VerdictSkip = 10 // Skipped
+	VerdictHack = 11 // Hacked
+)
+
 // SubmissionsPage returns link to user submissions page.
 func (arg Args) SubmissionsPage(handle string) (link string, err error) {
 	// Contest not specified.
@@ -214,14 +233,34 @@ func (arg Args) parseSubmissions(page *rod.Page) ([]Submission, bool) {
 				submissionRow.Language = language
 
 			case 5:
-				isJudging := cell.AttrOr("waiting", "") == "true"
-				submissionRow.IsJudging = isJudging
-				if isJudging == true {
-					isDone = false
-				}
-
 				verdict := clean(cell.Text())
 				submissionRow.Verdict = verdict
+				submissionRow.IsJudging = true
+
+				verdictMap := map[string]int{
+					"Accepted":                VerdictAC,
+					"Wrong answer":            VerdictWA,
+					"Runtime error":           VerdictRTE,
+					"Compilation error":       VerdictCE,
+					"Time limit exceeded":     VerdictTLE,
+					"Memory limit exceeded":   VerdictMLE,
+					"Idleness limit exceeded": VerdictILE,
+					"Denial of judgement":     VerdictDOJ,
+					"Skipped":                 VerdictSkip,
+					"Hacked":                  VerdictHack,
+				}
+
+				for k, v := range verdictMap {
+					if strings.Contains(verdict, k) {
+						submissionRow.VerdictStatus = v
+						submissionRow.IsJudging = false
+						break
+					}
+				}
+
+				if submissionRow.IsJudging == true {
+					isDone = false
+				}
 
 			case 6:
 				time := clean(cell.Text())

codeforces/submissions_test.go

@@ -160,52 +160,56 @@ func TestArgs_GetSubmissions(t *testing.T) {
 			args: args{"cp-tools", 1},
 			want: []Submission{
 				{
-					ID:        "81327550",
-					When:      time.Date(2020, time.May, 24, 19, 14, 0, 0, time.UTC),
-					Who:       "cp-tools",
-					Problem:   "A - Watermelon",
-					Language:  "GNU C++17",
-					Verdict:   "Compilation error",
-					Time:      "0 ms",
-					Memory:    "0 KB",
-					IsJudging: false,
-					Arg:       Args{"4", "a", "contest", ""},
+					ID:            "81327550",
+					When:          time.Date(2020, time.May, 24, 19, 14, 0, 0, time.UTC),
+					Who:           "cp-tools",
+					Problem:       "A - Watermelon",
+					Language:      "GNU C++17",
+					Verdict:       "Compilation error",
+					VerdictStatus: VerdictCE,
+					Time:          "0 ms",
+					Memory:        "0 KB",
+					IsJudging:     false,
+					Arg:           Args{"4", "a", "contest", ""},
 				},
 				{
-					ID:        "81327395",
-					When:      time.Date(2020, time.May, 24, 19, 12, 0, 0, time.UTC),
-					Who:       "cp-tools",
-					Problem:   "A - Watermelon",
-					Language:  "GNU C++17",
-					Verdict:   "Compilation error",
-					Time:      "0 ms",
-					Memory:    "0 KB",
-					IsJudging: false,
-					Arg:       Args{"4", "a", "contest", ""},
+					ID:            "81327395",
+					When:          time.Date(2020, time.May, 24, 19, 12, 0, 0, time.UTC),
+					Who:           "cp-tools",
+					Problem:       "A - Watermelon",
+					Language:      "GNU C++17",
+					Verdict:       "Compilation error",
+					VerdictStatus: VerdictCE,
+					Time:          "0 ms",
+					Memory:        "0 KB",
+					IsJudging:     false,
+					Arg:           Args{"4", "a", "contest", ""},
 				},
 				{
-					ID:        "81012854",
-					When:      time.Date(2020, time.May, 23, 12, 10, 0, 0, time.UTC),
-					Who:       "cp-tools",
-					Problem:   "B - Before an Exam",
-					Language:  "Ruby",
-					Verdict:   "Runtime error on test 2",
-					Time:      "46 ms",
-					Memory:    "0 KB",
-					IsJudging: false,
-					Arg:       Args{"4", "b", "contest", ""},
+					ID:            "81012854",
+					When:          time.Date(2020, time.May, 23, 12, 10, 0, 0, time.UTC),
+					Who:           "cp-tools",
+					Problem:       "B - Before an Exam",
+					Language:      "Ruby",
+					Verdict:       "Runtime error on test 2",
+					VerdictStatus: VerdictRTE,
+					Time:          "46 ms",
+					Memory:        "0 KB",
+					IsJudging:     false,
+					Arg:           Args{"4", "b", "contest", ""},
 				},
 				{
-					ID:        "81011111",
-					When:      time.Date(2020, time.May, 23, 11, 45, 0, 0, time.UTC),
-					Who:       "cp-tools",
-					Problem:   "A - Watermelon",
-					Language:  "GNU C++17",
-					Verdict:   "Accepted",
-					Time:      "62 ms",
-					Memory:    "0 KB",
-					IsJudging: false,
-					Arg:       Args{"4", "a", "contest", ""},
+					ID:            "81011111",
+					When:          time.Date(2020, time.May, 23, 11, 45, 0, 0, time.UTC),
+					Who:           "cp-tools",
+					Problem:       "A - Watermelon",
+					Language:      "GNU C++17",
+					Verdict:       "Accepted",
+					VerdictStatus: VerdictAC,
+					Time:          "62 ms",
+					Memory:        "0 KB",
+					IsJudging:     false,
+					Arg:           Args{"4", "a", "contest", ""},
 				},
 			},
 			wantErr: false,
@@ -216,16 +220,17 @@ func TestArgs_GetSubmissions(t *testing.T) {
 			args: args{"cp-tools", 1e9},
 			want: []Submission{
 				{
-					ID:        "81012854",
-					When:      time.Date(2020, time.May, 23, 12, 10, 0, 0, time.UTC),
-					Who:       "cp-tools",
-					Problem:   "B - Before an Exam",
-					Language:  "Ruby",
-					Verdict:   "Runtime error on test 2",
-					Time:      "46 ms",
-					Memory:    "0 KB",
-					IsJudging: false,
-					Arg:       Args{"4", "b", "contest", ""},
+					ID:            "81012854",
+					When:          time.Date(2020, time.May, 23, 12, 10, 0, 0, time.UTC),
+					Who:           "cp-tools",
+					Problem:       "B - Before an Exam",
+					Language:      "Ruby",
+					Verdict:       "Runtime error on test 2",
+					VerdictStatus: VerdictRTE,
+					Time:          "46 ms",
+					Memory:        "0 KB",
+					IsJudging:     false,
+					Arg:           Args{"4", "b", "contest", ""},
 				},
 			},
 			wantErr: false,