Fix warnings and errors

vinniefalco · vinniefalco · commit 9ab3c24b6778 · 2021-11-17T17:52:55.000-08:00
diff --git a/include/boost/http_proto.hpp b/include/boost/http_proto.hpp
@@ -52,6 +52,6 @@
 #include <boost/http_proto/codec/deflate_service.hpp>
 #include <boost/http_proto/codec/encoder.hpp>
 
-#include <boost/http_proto/mime/mime.hpp>
+#include <boost/http_proto/mime/mime_types.hpp>
 
 #endif
diff --git a/include/boost/http_proto/basic_header.hpp b/include/boost/http_proto/basic_header.hpp
@@ -23,7 +23,8 @@ namespace http_proto {
         @ref request, @ref request_view,
         @ref response, @ref response_view
 */
-class basic_header
+class BOOST_SYMBOL_VISIBLE
+    basic_header
 {
 public:
     /** Destructor
diff --git a/include/boost/http_proto/bnf/range.hpp b/include/boost/http_proto/bnf/range.hpp
@@ -42,10 +42,8 @@ class range
 
     class iterator;
 
-    constexpr range(
-        range const&) = default;
-    constexpr range& operator=(
-        range const&) = default;
+    range(range const&) = default;
+    range& operator=(range const&) = default;
 
     /** Default constructor
 
diff --git a/include/boost/http_proto/bnf/type_traits.hpp b/include/boost/http_proto/bnf/type_traits.hpp
@@ -57,10 +57,13 @@ struct is_element<T, boost::void_t<
         std::declval<char const*>(),
         std::declval<char const*>(),
         std::declval<error_code&>())
-            )>> : std::integral_constant<bool,
+            )>> : std::true_type
+#if 0
+std::integral_constant<bool,
     std::is_default_constructible<T>::value &&
     std::is_copy_constructible<T>::value &&
     std::is_copy_assignable<T>::value>
+#endif
 {
 };
 
@@ -101,10 +104,13 @@ struct is_list<T, boost::void_t<decltype(
         std::declval<char const*>(),
         std::declval<char const*>(),
         std::declval<error_code&>())
-            )>> : std::integral_constant<bool,
+    )>> : std::true_type
+#if 0
+    std::integral_constant<bool,
     std::is_default_constructible<T>::value &&
     std::is_copy_constructible<T>::value &&
     std::is_copy_assignable<T>::value>
+#endif
 {
 };
 
diff --git a/include/boost/http_proto/codec/decoder.hpp b/include/boost/http_proto/codec/decoder.hpp
@@ -19,7 +19,8 @@
 namespace boost {
 namespace http_proto {
 
-class decoder
+class BOOST_SYMBOL_VISIBLE
+    decoder
 {
 public:
     struct buffers
@@ -41,7 +42,8 @@ class decoder
 
 //------------------------------------------------
 
-class decoder_type
+class BOOST_SYMBOL_VISIBLE
+    decoder_type
 {
 public:
     virtual
diff --git a/include/boost/http_proto/codec/encoder.hpp b/include/boost/http_proto/codec/encoder.hpp
@@ -19,7 +19,8 @@
 namespace boost {
 namespace http_proto {
 
-class encoder
+class BOOST_SYMBOL_VISIBLE
+    encoder
 {
 public:
     struct buffers
@@ -41,7 +42,8 @@ class encoder
 
 //------------------------------------------------
 
-class encoder_type
+class BOOST_SYMBOL_VISIBLE
+    encoder_type
 {
 public:
     virtual
diff --git a/include/boost/http_proto/context.hpp b/include/boost/http_proto/context.hpp
@@ -20,15 +20,15 @@ namespace http_proto {
 
 #ifndef BOOST_HTTP_PROTO_DOCS
 class codecs;
-class mime;
+class mime_types;
 #endif
 
 class context
 {
     struct data;
 
-    codecs* codecs_;
-    mime* mime_;
+    http_proto::codecs* codecs_;
+    http_proto::mime_types* mime_types_;
 
 public:
     struct service
@@ -53,10 +53,10 @@ class context
         return *codecs_;
     }
 
-    http_proto::mime&
-    mime() noexcept
+    http_proto::mime_types&
+    mime_types() noexcept
     {
-        return *mime_;
+        return *mime_types_;
     }
 
     //--------------------------------------------
diff --git a/include/boost/http_proto/headers.hpp b/include/boost/http_proto/headers.hpp
@@ -26,7 +26,8 @@ enum class field : unsigned short;
 class headers_view;
 #endif
 
-class headers : public basic_header
+class BOOST_SYMBOL_VISIBLE
+    headers : public basic_header
 {
     // headers have a maximum size of 2^32-1 chars
     using off_t = std::uint32_t;
@@ -45,13 +46,11 @@ class headers : public basic_header
     static constexpr std::size_t
         max_header_size_ = ((off_t)(-1));
 
-    constexpr
     static
     std::size_t
     align_up(
         std::size_t n) noexcept;
 
-    constexpr
     static
     std::size_t
     bytes_needed(
diff --git a/include/boost/http_proto/headers_view.hpp b/include/boost/http_proto/headers_view.hpp
@@ -26,7 +26,9 @@ enum class field : unsigned short;
 
 /** A read-only, random access container of HTTP fields
 */
-class headers_view : public basic_header
+class BOOST_SYMBOL_VISIBLE
+    headers_view
+    : public basic_header
 {
     // headers have a maximum size of 2^32-1 chars
     using off_t = std::uint32_t;
diff --git a/include/boost/http_proto/impl/context.hpp b/include/boost/http_proto/impl/context.hpp
@@ -51,11 +51,9 @@ make_service(
                     Args>(args)...))));
 }
 
-template<class T, class... Args>
+template<class T>
 T*
-find_service(
-    context& ctx,
-    Args&&... args)
+find_service(context& ctx) noexcept
 {
     auto const ti = std::type_index(
         typeid(detail::get_key_type<T>));
@@ -68,8 +66,7 @@ find_service(
 
 template<class T>
 T&
-get_service(
-    context& ctx)
+get_service(context& ctx)
 {
     auto ps = find_service<T>();
     if(! ps)
diff --git a/include/boost/http_proto/impl/context.ipp b/include/boost/http_proto/impl/context.ipp
@@ -20,7 +20,7 @@ namespace http_proto {
 
 namespace detail {
 codecs& install_codecs_service(context& ctx);
-mime& install_mime_service(context& ctx);
+mime_types& install_mime_types_service(context& ctx);
 } // detail
 
 struct context::data
@@ -50,7 +50,7 @@ context() noexcept
     : p_(new data)
 {
     codecs_ = &detail::install_codecs_service(*this);
-    mime_ = &detail::install_mime_service(*this);
+    mime_types_ = &detail::install_mime_types_service(*this);
 }
 
 //------------------------------------------------
diff --git a/include/boost/http_proto/impl/headers.ipp b/include/boost/http_proto/impl/headers.ipp
@@ -41,7 +41,6 @@ s_owner_[3] = {
 };
 
 // also applies min capacity
-constexpr
 std::size_t
 headers::
 align_up(std::size_t n) noexcept
@@ -61,7 +60,6 @@ align_up(std::size_t n) noexcept
 // returns minimum capacity to hold
 // size characters and count table
 // entries, including alignment.
-constexpr
 std::size_t
 headers::
 bytes_needed(
@@ -369,7 +367,7 @@ find(field id) const noexcept ->
     auto const* ft =
         &detail::get_ftab(
             buf_ + cap_)[0];
-    for(auto i = 0;
+    for(std::size_t i = 0;
             i < count_; ++i, --ft)
         if(ft->id == id)
             return iterator(this, i);
@@ -611,7 +609,7 @@ insert(
     {
         // first allocation
         auto empty = s_owner_[owner_];
-        auto constexpr min_cap =
+        auto const min_cap =
             align_up(256 + 8 *
             sizeof(detail::fitem));
         // prevent small allocs
diff --git a/include/boost/http_proto/impl/parser.ipp b/include/boost/http_proto/impl/parser.ipp
@@ -749,7 +749,7 @@ do_transfer_encoding(
         if(it == end)
         {
             if(bnf::iequals(
-                it->name, "chunked"))
+                prev->name, "chunked"))
                 m_.got_chunked = true;
             break;
         }
diff --git a/include/boost/http_proto/impl/request.ipp b/include/boost/http_proto/impl/request.ipp
@@ -20,7 +20,7 @@ namespace http_proto {
 
 request::
 request()
-    : method_(method::get)
+    : method_(http_proto::method::get)
     , version_(http_proto::version::http_1_1)
     , method_len_(3)
     , target_len_(1)
diff --git a/include/boost/http_proto/impl/response.ipp b/include/boost/http_proto/impl/response.ipp
@@ -21,8 +21,8 @@ namespace http_proto {
 
 response::
 response()
-    : version_(version::http_1_1)
-    , result_(status::ok)
+    : version_(http_proto::version::http_1_1)
+    , result_(http_proto::status::ok)
     , fields(2)
 {
 }
diff --git a/include/boost/http_proto/mime/impl/mime_types.ipp b/include/boost/http_proto/mime/impl/mime_types.ipp
@@ -7,30 +7,30 @@
 // Official repository: https://github.com/CPPAlliance/http_proto
 //
 
-#ifndef BOOST_HTTP_PROTO_MIME_IMPL_MIME_IPP
-#define BOOST_HTTP_PROTO_MIME_IMPL_MIME_IPP
+#ifndef BOOST_HTTP_PROTO_MIME_IMPL_MIME_TYPES_IPP
+#define BOOST_HTTP_PROTO_MIME_IMPL_MIME_TYPES_IPP
 
-#include <boost/http_proto/mime/mime.hpp>
+#include <boost/http_proto/mime/mime_types.hpp>
 #include <boost/http_proto/context.hpp>
 #include <boost/http_proto/bnf/ctype.hpp>
 
 namespace boost {
 namespace http_proto {
 
-mime::
-~mime() noexcept = default;
+mime_types::
+~mime_types() noexcept = default;
 
 namespace detail {
 
-class mime_impl
-    : public mime
+class mime_types_impl
+    : public mime_types
     , public context::service
 {
 public:
-    using key_type = mime;
+    using key_type = mime_types;
 
     explicit
-    mime_impl(
+    mime_types_impl(
         context&) noexcept
     {
     }
@@ -43,11 +43,11 @@ public:
     }
 };
 
-mime&
-install_mime_service(
+mime_types&
+install_mime_types_service(
     context& ctx)
 {
-    return make_service<mime_impl>(ctx);
+    return make_service<mime_types_impl>(ctx);
 }
 
 } // detail
diff --git a/include/boost/http_proto/mime/mime_types.hpp b/include/boost/http_proto/mime/mime_types.hpp
@@ -7,20 +7,21 @@
 // Official repository: https://github.com/CPPAlliance/http_proto
 //
 
-#ifndef BOOST_HTTP_PROTO_MIME_MIME_HPP
-#define BOOST_HTTP_PROTO_MIME_MIME_HPP
+#ifndef BOOST_HTTP_PROTO_MIME_MIME_TYPES_HPP
+#define BOOST_HTTP_PROTO_MIME_MIME_TYPES_HPP
 
 #include <boost/http_proto/detail/config.hpp>
 #include <boost/http_proto/string_view.hpp>
 
 namespace boost {
 namespace http_proto {
 
-class mime
+class BOOST_SYMBOL_VISIBLE
+    mime_types
 {
 public:
     BOOST_HTTP_PROTO_DECL
-    virtual ~mime() noexcept;
+    virtual ~mime_types() noexcept;
 
     virtual
     string_view
diff --git a/include/boost/http_proto/parser.hpp b/include/boost/http_proto/parser.hpp
@@ -49,7 +49,8 @@ struct chunk_info
     HTTP ABNFs is treated as an
     unrecoverable error.
 */
-class parser
+class BOOST_SYMBOL_VISIBLE
+    parser
 {
 BOOST_HTTP_PROTO_PROTECTED:
     // headers have a maximum size of 2^32-1 chars
diff --git a/include/boost/http_proto/request.hpp b/include/boost/http_proto/request.hpp
@@ -25,7 +25,9 @@ class request_view;
 
 /** Container for HTTP requests
 */
-class request : public basic_header
+class BOOST_SYMBOL_VISIBLE
+    request
+    : public basic_header
 {
     http_proto::method method_;
     http_proto::version version_;
diff --git a/include/boost/http_proto/request_parser.hpp b/include/boost/http_proto/request_parser.hpp
@@ -21,7 +21,8 @@
 namespace boost {
 namespace http_proto {
 
-class request_parser
+class BOOST_SYMBOL_VISIBLE
+    request_parser
     : public parser
 {
     http_proto::method method_;
diff --git a/include/boost/http_proto/request_view.hpp b/include/boost/http_proto/request_view.hpp
@@ -24,7 +24,9 @@ enum class method : char;
 enum class version : char;
 #endif
 
-class request_view : public basic_header
+class BOOST_SYMBOL_VISIBLE
+    request_view
+    : public basic_header
 {
     // headers have a maximum size of 2^32-1 chars
     using off_t = std::uint32_t;
diff --git a/include/boost/http_proto/response.hpp b/include/boost/http_proto/response.hpp
diff --git a/include/boost/http_proto/response_parser.hpp b/include/boost/http_proto/response_parser.hpp
diff --git a/include/boost/http_proto/response_view.hpp b/include/boost/http_proto/response_view.hpp
diff --git a/include/boost/http_proto/serializer.hpp b/include/boost/http_proto/serializer.hpp
diff --git a/include/boost/http_proto/src.hpp b/include/boost/http_proto/src.hpp
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
diff --git a/test/Jamfile b/test/Jamfile
diff --git a/test/bnf/ctype.cpp b/test/bnf/ctype.cpp
diff --git a/test/mime/mime_types.cpp b/test/mime/mime_types.cpp
diff --git a/test/response_parser.cpp b/test/response_parser.cpp
