Inconsistent Interface Contracts for Metrics/Patterns (AST vs. Filepath)

[AntonProkopyev]

The current codebase exhibits inconsistencies in metric and pattern interfaces, where some implementations accept an ast while others take a filepath. Additionally, the unstructured use of dictionaries in config and main complicates maintenance and refactoring.

Historical commit patterns suggest that the intended contract operates on an ast (Abstract Syntax Tree), but this is not formally enforced, leading to potential bugs and technical debt.

[0pdd]

@AntonProkopyev 3 puzzles #820, #821, #822 are still not solved.

[0pdd]

@AntonProkopyev 3 puzzles #820, #829, #830 are still not solved; solved: #821, #822.

[0pdd]

@AntonProkopyev 2 puzzles #829, #830 are still not solved; solved: #820, #821, #822.

[0pdd]

@AntonProkopyev the puzzle #829 is still not solved; solved: #820, #821, #822, #830.

[ivanovmg]

@AntonProkopyev I found that implementation of the desirable interface for some metrics, including, but not limited to Entropy, LCOM4, IndentationCounter, is not feasible.
The problem is that this code relies on the actual source code and/or javalang nodes, rather than aibolit.ast.ASTNode objects.
I guess, it is still possible to implement, but it is likely to go against the grain.
What do you think?

[AntonProkopyev]

@ivanovmg Current implementation of the CLI supports only mestrics collected with AST, so I see various solutions here:

1. Refactor each metric one-by-one to support AST to implement Metric protocol then enable it in the config
2. Refactor CLI and refactor Metric protocol, to support each metric
3. Combination of solutions (1) and (2)

IMO finally there should be no metrics left in the code that are not used in the product

[0crat]

@AntonProkopyev Thanks for reporting a new bug! You've earned +12 points. By reporting bugs, you help our project improve its quality. If you find anything else in the repository that doesn't look as good as you might expect, do not hesitate to report it. Your running balance is +96.