Skip to content

Commit 559a290

Browse files
committed
use little trick to order libargon2 before libsodium
1 parent fff2484 commit 559a290

File tree

3 files changed

+3
-20
lines changed

3 files changed

+3
-20
lines changed

config/lib.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,9 @@
361361
"source": "libargon2",
362362
"static-libs-unix": [
363363
"libargon2.a"
364+
],
365+
"lib-suggests": [
366+
"libsodium"
364367
]
365368
},
366369
"libavif": {

src/SPC/builder/extension/password_argon2.php

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -24,25 +24,6 @@ public function runCliCheckUnix(): void
2424
}
2525
}
2626

27-
public function patchBeforeMake(): bool
28-
{
29-
$patched = parent::patchBeforeMake();
30-
if ($this->builder->getLib('libsodium') !== null) {
31-
$extraLibs = getenv('SPC_EXTRA_LIBS');
32-
if ($extraLibs !== false) {
33-
$extraLibs = str_replace(
34-
[BUILD_LIB_PATH . '/libargon2.a', BUILD_LIB_PATH . '/libsodium.a'],
35-
['', BUILD_LIB_PATH . '/libargon2.a ' . BUILD_LIB_PATH . '/libsodium.a'],
36-
$extraLibs,
37-
);
38-
$extraLibs = trim(preg_replace('/\s+/', ' ', $extraLibs)); // normalize spacing
39-
f_putenv('SPC_EXTRA_LIBS=' . $extraLibs);
40-
return true;
41-
}
42-
}
43-
return $patched;
44-
}
45-
4627
public function getConfigureArg(bool $shared = false): string
4728
{
4829
if ($this->builder->getLib('openssl') !== null) {

src/SPC/util/SPCConfigUtil.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ public function config(array $extensions = [], array $libraries = [], bool $incl
8080
$libs = $this->getLibsString($libraries, !$this->absolute_libs);
8181

8282
// additional OS-specific libraries (e.g. macOS -lresolv)
83-
// embed
8483
if ($extra_libs = SPCTarget::getRuntimeLibs()) {
8584
$libs .= " {$extra_libs}";
8685
}

0 commit comments

Comments
 (0)