Integrate check-build into lint pipeline

Author: valeriansaliou

.checkbuild

@@ -13,7 +13,7 @@
   "disallowQuotedKeysInObjects": true,
   "disallowSpacesInsideParentheses": true,
   "disallowKeywordsOnNewLine": ["else"],
-  "disallowIdentifierNames": [],
+  "disallowIdentifierNames": ["console"],
 
   "requireCurlyBraces": true,
   "requireDotNotation": true,

.jscsrc

@@ -86,6 +86,8 @@ var ENV_AVAILABLE     = [
 
 // METHODS
 
+// jscs:disable disallowIdentifierNames
+
 function run() {
   // Run help?
   if (args.help) {
@@ -330,6 +332,8 @@ function setup_gulp_logging(instance) {
   });
 }
 
+// jscs:enable disallowIdentifierNames
+
 
 // CALLS
 

bin/chappe.js

@@ -36,6 +36,8 @@ var gulp_replace         = require("gulp-replace");
 var gulp_header          = require("gulp-header");
 var gulp_pug_lint        = require("gulp-pug-lint");
 var gulp_sass_lint       = require("gulp-sass-lint");
+var gulp_jshint          = require("gulp-jshint");
+var gulp_jscs            = require("gulp-jscs");
 var gulp_sizereport      = require("gulp-sizereport");
 var gulp_sitemap         = require("gulp-sitemap");
 var gulp_notify          = require("gulp-notify");
@@ -1310,6 +1312,48 @@ var lint_sass_stylesheets = function() {
 };
 
 
+/*
+  Lints JS scripts (with JSHint)
+*/
+var lint_js_scripts_jshint = function() {
+  return gulp.src([
+    CONTEXT.PATH_SOURCES + "/javascripts/**/*.js",
+    CONTEXT.PATH_CHAPPE + "/bin/*.js"
+  ])
+    .pipe(
+      gulp_jshint({
+        defaultFile : path.join(
+          CONTEXT.PATH_CHAPPE, ".jshintrc"
+        )
+      })
+    )
+    .pipe(
+      gulp_jshint.reporter("fail")
+    );
+};
+
+
+/*
+  Lints JS scripts (with JSCS)
+*/
+var lint_js_scripts_jscs = function() {
+  return gulp.src([
+    CONTEXT.PATH_SOURCES + "/javascripts/**/*.js",
+    CONTEXT.PATH_CHAPPE + "/bin/*.js"
+  ])
+    .pipe(
+      gulp_jscs({
+        configPath : path.join(
+          CONTEXT.PATH_CHAPPE, ".jscsrc"
+        )
+      })
+    )
+    .pipe(
+      gulp_jscs.reporter("fail")
+    );
+};
+
+
 /*
   Lints project built code
 */
@@ -1319,7 +1363,9 @@ var lint = function() {
 
     gulp.parallel(
       lint_jade_templates,
-      lint_sass_stylesheets
+      lint_sass_stylesheets,
+      lint_js_scripts_jshint,
+      lint_js_scripts_jscs
     )
   );
 }();

gulpfile.js

@@ -38,10 +38,7 @@
     "build": "./bin/chappe.js build --example=crisp-docs",
     "clean": "./bin/chappe.js clean --example=crisp-docs",
     "dev": "./bin/chappe.js build --example=crisp-docs && ./bin/chappe.js watch --example=crisp-docs",
-    "test": "check-build && ./bin/chappe.js lint --example=crisp-docs"
-  },
-  "devDependencies": {
-    "check-build": "2.8.2"
+    "test": "./bin/chappe.js lint --example=crisp-docs"
   },
   "dependencies": {
     "babel-preset-es2015": "6.9.x",
@@ -67,8 +64,11 @@
     "gulp-replace": "1.1.x",
     "gulp-pug-lint": "0.1.x",
     "gulp-sass-lint": "1.4.x",
+    "gulp-jshint": "2.1.x",
+    "gulp-jscs": "4.1.x",
     "gulp-sizereport": "1.2.x",
     "gulp-notify": "4.0.x",
+    "jshint": "2.13.x",
     "marked": "4.0.x",
     "markdown-toc": "1.2.x",
     "drafter": "2.0.x",