activeControlGroup without has-error class support

[fedek6]

Hi,
When there is error in a field activeControlGroup does not add has-error CSS class to it's container or print error message below.

echo TbHtml::activeControlGroup(TbHtml::INPUT_TYPE_TEXT, $model, 'username' );

Maybe I'm doing something wrong?

Variable $errorCss is not used anywhere across TbHtml class.

[fedek6]

This fix works for me:

if( !empty( $model->getErrors( $attribute ) ) ) { self::addCssClass( self::$errorCss, $groupOptions); }

At the end of activeControlGroup method of the TbHtml class.

[marcovtwout]

What happens when you just use TbHtml::activeTextField()? I'm not sure if activeControlGroup() is meant to be called directly.

[fedek6]

It adds class error to the input field but it's not compatible with bootstrap. It should look like this: `

Input with error

` instead of ``. Maybe I should render form using some other method?

[marcovtwout]

It works as expected when using a TbForm or TbActiveForm.

Your view code for example calls $form->textFieldControlGroup(). This calls processControlGroupOptions() first (and sets the error class) before calling TbHtml::activeControlGroup().

As these are valid workarounds, it still looks like you found an inconsistency in the API.

[crisu83]

@fedek6 maybe you can create a PR to fix this issue so that we can merge it into the project?