Skip to content

Commit 8c0b7f7

Browse files
authored
Merge pull request #74 from criteo/optional-phys-context
bmc: make PhysicalContext and PowerConsumedWatts optional
2 parents 8132d82 + 5253595 commit 8c0b7f7

File tree

1 file changed

+2
-2
lines changed
  • hwbench/environment/vendors

1 file changed

+2
-2
lines changed

hwbench/environment/vendors/bmc.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ def read_thermals(
152152

153153
super().add_monitoring_value(
154154
cast(dict[str, dict[str, MonitorMetric]], thermals),
155-
t["PhysicalContext"],
155+
t.get("PhysicalContext", "UnknownPhysicalContext"),
156156
Temperature(name),
157157
t["Name"],
158158
t["ReadingCelsius"],
@@ -196,7 +196,7 @@ def read_power_consumption(
196196
if str(PowerContext.BMC) not in power_consumption:
197197
power_consumption[str(PowerContext.BMC)] = {str(PowerCategories.SERVER): Power(str(PowerCategories.SERVER))} # type: ignore[no-redef]
198198

199-
power = self.get_power().get("PowerControl", [{"PowerConsumedWatts": None}])[0]["PowerConsumedWatts"]
199+
power = self.get_power().get("PowerControl", [{"PowerConsumedWatts": None}])[0].get("PowerConsumedWatts", None)
200200
if power:
201201
power_consumption[str(PowerContext.BMC)][str(PowerCategories.SERVER)].add(power)
202202
return power_consumption

0 commit comments

Comments
 (0)