Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec.type to Node Disruption API #64

Open
geobeau opened this issue Jun 6, 2024 · 0 comments
Open

Add spec.type to Node Disruption API #64

geobeau opened this issue Jun 6, 2024 · 0 comments

Comments

@geobeau
Copy link
Contributor

geobeau commented Jun 6, 2024

Spec type will contains the type of the disruption. This type is a set of arbitrary strings such as: "decommission", "reboot", etc.

There should be a way to specify an allow list of types (so we can control which types are supported). It will have the following requirements:

  • It will be given to the CLI of the controller
  • It will default to empty, which will mean allow all
  • If a node disruption is created, it should be rejected right away with an explicit error message (message should include the list)

This type should also be used to segregate metrics (both budget and node disruption) to allow better observability.
FatmaBouzghaia pushed a commit to FatmaBouzghaia/node-disruption-controller that referenced this issue Jun 24, 2024
Implement spec.type to Node Disruption API [criteo#64]
4ce150b 
Signed-off-by: f.bouzghaia <[email protected]>
FatmaBouzghaia pushed a commit to FatmaBouzghaia/node-disruption-controller that referenced this issue Jun 25, 2024
Add metrics for Node disruption type [criteo#64]
e9dea84 
Signed-off-by: f.bouzghaia <[email protected]>
FatmaBouzghaia pushed a commit to FatmaBouzghaia/node-disruption-controller that referenced this issue Jun 25, 2024
Add metrics for Node disruption type [criteo#64]
5b2859e 
Signed-off-by: f.bouzghaia <[email protected]>
FatmaBouzghaia pushed a commit to FatmaBouzghaia/node-disruption-controller that referenced this issue Jun 28, 2024
Implement spec.type to Node Disruption API [criteo#64]
e909cad 
Signed-off-by: f.bouzghaia <[email protected]>
FatmaBouzghaia pushed a commit to FatmaBouzghaia/node-disruption-controller that referenced this issue Jun 28, 2024
Add metrics for Node disruption type [criteo#64]
579f422 
Signed-off-by: f.bouzghaia <[email protected]>
FatmaBouzghaia pushed a commit to FatmaBouzghaia/node-disruption-controller that referenced this issue Jun 28, 2024
Add metrics for Node disruption type [criteo#64]
17a68e4 
Signed-off-by: f.bouzghaia <[email protected]>
geobeau pushed a commit that referenced this issue Jun 28, 2024
@FatmaBouzghaia
Implement spec.type to Node Disruption API (#67)
1376a1d 
Implement #64

Signed-off-by: f.bouzghaia <[email protected]>
Co-authored-by: f.bouzghaia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geobeau