Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the use of configuration source remote and inline at the same time #26

Open
morningspace opened this issue Apr 6, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@morningspace
Copy link
Collaborator

For the configuration source, we have two options, remote and inline, which are now mutual exclusive. Can we support the use of both at the same time? The reason for that:

The remote option would be more useful in real projects, as usually people will run Ansible automation using a bunch of well-organized yaml stuff, rather than a single playbook.yml file. The inline option would be more likely for demo purpose.

However, there is one use case that probably can lead us to use both remote and inline at the same time. When call one or more roles as reusable building blocks from somewhere such as git repo or ansible galaxy, people often create playbook on top of that w/ some additional twists. This playbook may not be part of the existing contents in repos, but instead, is created on the fly, which can nicely be implemented by the inline option.

@morningspace morningspace added the enhancement New feature or request label Apr 6, 2022
@morningspace
Copy link
Collaborator Author

@fahedouch Just to confirm:

According to https://github.com/multicloudlab/crossplane-provider-ansible/blob/main/internal/ansible/ansible.go#L245-L246, I assume that the current implementation will not support the case logged in this issue, i.e.: playbookInline calls roles retrieved from a remote repo, right?

Also, what will happen when people define playbookInline and playbooks at the same time. This if branch seems haven't been covered yet.

P.S.: It will be fine if that has been implemented yet. We can update it in the coming releases.

@fahedouch
Copy link
Collaborator

fahedouch commented May 20, 2022

Hey @morningspace ,

Yes the actual release do not support remote and inline at the same time. We try add gradually this features :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants