Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only the last message fragment is sent #21

Open
weinholt opened this issue Jan 13, 2013 · 10 comments
Open

Only the last message fragment is sent #21

weinholt opened this issue Jan 13, 2013 · 10 comments
Labels

Comments

@weinholt
Copy link

When sending encrypted messages that need to be fragmented, only the last fragment is actually sent to the IRC server. I can reproduce this by connecting two irssi clients to the same IRC server, initiating an OTR session between them and sending an 80 character line from one client to the other. "/rawlog save" only shows the fragment that starts with "?OTR|...|...,00002,00002,".

I've tested this with irssi 0.8.15-5 and ibotr5 4.0.0-2 on Debian wheezy amd64 with irssi-otr v1.0.0-alpha1-5-g5f685aa from git.

@dgoulet
Copy link
Member

dgoulet commented Jan 13, 2013

This has been observed by some people in the last days indeed. Thanks for this. This is obviously a big priority.

@dgoulet
Copy link
Member

dgoulet commented Jan 19, 2013

This seems like an libotr upstream problem. I'm waiting for a patch to be accepted.

http://lists.cypherpunks.ca/pipermail/otr-dev/2013-January/001549.html

@dgoulet
Copy link
Member

dgoulet commented Jan 24, 2013

Still waiting for the patch to be upstream so I'll add it here since it's pretty trivial.

http://ev0ke.net/0001-Fix-pass-opdata-when-sending-message-fragment.patch

@dgoulet dgoulet mentioned this issue Apr 13, 2013
@anarcat
Copy link
Contributor

anarcat commented May 9, 2013

Shouldn't this be closed, considering it's a bug in libotr?

@dgoulet
Copy link
Member

dgoulet commented May 9, 2013

I don't think so because this package does not work properly with upstream libotr and keeping this opened acknowledge the issue and even provide a fix. Until we see the fix in upstream libotr, I really think this should be kept open because other distros (like Arch or even Ubuntu) are not providing a fix for libotr.

@dgoulet
Copy link
Member

dgoulet commented Sep 6, 2013

Ok so this is upstream in libotr right now. We are putting pressure on them to release a new version with that fix so packages stop applying this custom patch. Once a release is done, we'll close this one!

@anarcat
Copy link
Contributor

anarcat commented Sep 24, 2013

thanks! any timeline on that? or reference for the upstream issue, for that matter?

@DrWhax
Copy link
Member

DrWhax commented Sep 27, 2013

Ian needs to create a new libOTR release, it's upstream in the git repository.

@anarcat
Copy link
Contributor

anarcat commented Sep 28, 2013

well, that's what i meant: do we know when they will do a new release or where their bugtracker is?

@DrWhax
Copy link
Member

DrWhax commented Sep 28, 2013

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

There isn't really a bugtracker, there is a mailinglist however[1]
There is no indication of a new release, we can craft an email and ask
them? :)

[1] http://lists.cypherpunks.ca/mailman/listinfo/otr-de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQEcBAEBAgAGBQJSRtofAAoJELc5KWfqgB0C3aAH/jF4ErUbkSs7wp3Z/1O0byV2
SDTh0avv1qRexJgcXmmVoUkM9HlcWvBN48cQcS41LxX7Q/eoD7EtwpHvKbJd8xpw
ZKDiacj1gZe+1KOA6PDpqTNqIrkLd52vBh4aUDPrMBLyBHQeKPj86xr8fE0xKaxc
V4xvMA2JV92eGiNRugFCTWfT/iwh6HL4MhiwfFCDt/yHnJzCJSFnjfmpPALqYaqT
tPH8xWewFbzrsFRKEdV0GKB1LkzPtDM1L/N0UYMmXDebKMMVho68XiGnxQ/WEEyS
NvNY2vAsKTo810gzk9PANi6ccuFDV6UZa8kdkDDenNBSvyzZursaZYpKmMzOQLk=
=F3xs
-----END PGP SIGNATURE-----

chexxor pushed a commit to chexxor/nixos-configurations that referenced this issue Nov 6, 2013
I hope it doesn't make libotr insecure, but the trivial patch comes from
this irssi-otr thread:
cryptodotis/irssi-otr#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants