crystal-mode and tree-sitter

[peterhoeg]

emacs 29.1 will be getting native tree-sitter support and a number of major modes are currently being converted to utilize exactly that.

It would be awesome to have both tree-sitter support for crystal and a crystal-ts-mode to make use of it.

I don't realistically think I will have time to do it, but I would love to get it going....

[peterhoeg]

A quick follow-up. The grammar is there so we just need to adapt the emacs mode....

[MistressRemilia]

I have zero knowledge of tree-sitter. If support is added to crystal-mode, what happens on Emacsen that are compiled without tree-sitter support? Ideally supporting both tree-sitter-enabled Emacsen and ones without tree-sitter would be ideal. Perhaps it's a non-issue, though.

Like I'm on Slackware, and the system package for Emacs 30.2 on Slackware 15.0 is built without tree-sitter support. I've seen errors while recompiling all my .el files such as this one: ⛔ Warning (treesit): Cannot activate tree-sitter, because Emacs is not compiled with tree-sitter library

[peterhoeg]

There are 2 ways to do this: add TS support to the existing crystal-mode and use it when available, or create a new crystal-ts-mode Most of the existing major modes that have added TS support have gone for option 2 and I’m planning on taking a stab at that through that exact option. One thing to keep in mind - we have some functionality in crystal-mode that also will apply to crystal-ts-mode so we should probably look at extracting some of that functionality into a separate crystal-libs.el file so it can easily be shared. But that’s for later.