Skip to content

Remove return statement from test #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

Conversation

mdpiper
Copy link
Member

@mdpiper mdpiper commented Jun 3, 2025

The latest version of pytest throws an error if a test returns anything other than None. I've removed a return statement from one test in bmi-tester.

This fixes #50.

@mdpiper mdpiper marked this pull request as draft June 3, 2025 17:13
@mdpiper
Copy link
Member Author

mdpiper commented Jun 3, 2025

This PR exposed two unrelated maintenance issues:

  1. an outdated pre-commit hook, and
  2. use of Mambaforge in the CI test workflow

which I fixed in a pair of commits.

@mdpiper mdpiper marked this pull request as ready for review June 3, 2025 17:45
@mdpiper mdpiper requested a review from mcflugen June 3, 2025 17:45
@coveralls
Copy link

Coverage Status

coverage: 11.97% (+0.02%) from 11.952%
when pulling d60c92b on mdpiper/remove-return-value
into c4f5c99 on master.

Copy link
Member

@mcflugen mcflugen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mdpiper mdpiper merged commit 5a19d67 into master Jun 5, 2025
16 checks passed
@mdpiper mdpiper deleted the mdpiper/remove-return-value branch June 5, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest fails with non-None return
3 participants