Skip to content

Msbuilder #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Msbuilder #20

wants to merge 6 commits into from

Conversation

freiburgermsu
Copy link

Hello @cshenry !

Here are edits and comments for MSBuilder:

  1. unused imports are flagged
    
  2. variable names were clarified
    
  3. variable definitions are consolidated
    
  4. items() is leveraged for greater efficiency
    
  5. a new function _reaction_sinks is created from repeated code in the package
    
  6. an f-string replaces a formatted string for greater conciseness
    
  7. an error message was clarified
    
  8. lambda loops were replaced with faster and more concise list comprehension
    
  9. numerous and conditions were simplified with an any conditional
    
  10. an excessive I/O processing is flagged
    
  11. an unused solution variable is removed
    

Thank you so much :)
Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant