Skip to content

Commit 0295c8f

Browse files
committed
addressing comments from @aboada
1 parent 463b275 commit 0295c8f

File tree

5 files changed

+16
-6
lines changed

5 files changed

+16
-6
lines changed

src/mole_C++/divergence.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* @date 2024/10/15
77
*
88
*/
9+
910
#ifndef DIVERGENCE_H
1011
#define DIVERGENCE_H
1112

src/mole_C++/laplacian.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* @file laplacian.h
33
*
4-
* @brief Mimetic Laplacian Constructors
4+
* @brief Mimetic Laplacian Class and Constructors
55
*
66
* @date 2024/10/15
77
*

src/mole_C++/operators.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* @file operators.h
33
*
4-
* @brief Sparse operation inline definitions for mimetic members
4+
* @brief Sparse operation inline definitions for mimetic class constructions
55
* @date 2024/10/15
66
*
77
*/

src/mole_C++/utils.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,12 @@
99
*
1010
*/
1111

12-
1312
#include "utils.h"
1413
#include <cassert>
1514

1615
#ifdef EIGEN
1716
#include <eigen3/Eigen/SparseLU>
1817

19-
2018
vec Utils::spsolve_eigen(const sp_mat &A, const vec &b) {
2119
Eigen::SparseMatrix<Real> eigen_A(A.n_rows, A.n_cols);
2220
std::vector<Eigen::Triplet<Real>> triplets;

src/mole_C++/utils.h

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class Utils {
3333
static sp_mat spkron(const sp_mat &A, const sp_mat &B);
3434

3535
/**
36-
* @brief An in place oepration for joining two matrices by rows
36+
* @brief An in place operation for joining two matrices by rows
3737
*
3838
* @param A a sparse matrix
3939
* @param B a sparse matrix
@@ -48,7 +48,7 @@ class Utils {
4848
* @param A a sparse matrix
4949
* @param B a sparse matrix
5050
*
51-
* @note This is available in Armadillo >8.0
51+
* @note This is available in Armadillo >=8.5
5252
*/
5353
static sp_mat spjoin_cols(const sp_mat &A, const sp_mat &B);
5454

@@ -65,6 +65,13 @@ class Utils {
6565
/**
6666
* @brief An analog to the MATLAB 2D meshgrid operation
6767
*
68+
* returns 2-D grid coordinates based on the coordinates contained
69+
* in vectors x and y. X is a matrix where each row is a copy of x,
70+
* and Y is a matrix where each column is a copy of y. The grid
71+
* represented by the coordinates X and Y has length(y) rows and
72+
* length(x) columns. Key here is the rows is the y-coordinate, and
73+
* the columns are the x-coordinate.
74+
*
6875
* @param x a vector of x-indices
6976
* @param y a vector of y-indices
7077
* @param X a sparse matrix, will be filled by the function
@@ -76,6 +83,10 @@ class Utils {
7683
/**
7784
* @brief An analog to the MATLAB 3D meshgrid operation
7885
*
86+
* meshgrid(x,y,z,X,Y,Z) returns 3-D grid coordinates defined by the
87+
* vectors x, y, and z. The grid represented by X, Y, and Z has size
88+
* length(y)-by-length(x)-by-length(z).
89+
*
7990
* @param x a vector of x-indices
8091
* @param y a vector of y-indices
8192
* @param z a vector of z-indices

0 commit comments

Comments
 (0)