Skip to content

Commit a37d517

Browse files
kosackmaxnoe
authored andcommitted
Remove some obsolete TODOs
1 parent a0b2d89 commit a37d517

File tree

7 files changed

+4
-33
lines changed

7 files changed

+4
-33
lines changed

src/ctapipe/calib/camera/calibrator.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -244,12 +244,6 @@ def _calibrate_dl1(self, event, tel_id):
244244
waveforms -= np.atleast_2d(dl1_calib.pedestal_offset)[..., np.newaxis]
245245

246246
if n_samples == 1:
247-
# To handle ASTRI and dst
248-
# TODO: Improved handling of ASTRI and dst
249-
# - dst with custom EventSource?
250-
# - Read into dl1 container directly?
251-
# - Don't do anything if dl1 container already filled
252-
# - Update on SST review decision
253247
dl1 = DL1CameraContainer(
254248
image=np.squeeze(waveforms).astype(np.float32),
255249
peak_time=np.zeros(n_pixels, dtype=np.float32),
@@ -322,7 +316,7 @@ def __call__(self, event):
322316
event : container
323317
A `~ctapipe.containers.ArrayEventContainer` event container
324318
"""
325-
# TODO: How to handle different calibrations depending on tel_id?
319+
326320
tel = event.r1.tel or event.dl0.tel or event.dl1.tel
327321
for tel_id in tel.keys():
328322
self._calibrate_dl0(event, tel_id)

src/ctapipe/core/provenance.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
"""
22
Provenance-related functionality
3-
4-
TODO: have this register whenever ctapipe is loaded
5-
63
"""
74

85
import json

src/ctapipe/image/pixel_likelihood.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@
2121
neg_log_likelihood(image, prediction, spe, ped)
2222
59.9 µs per loop
2323
24-
TODO:
25-
=====
26-
- Need to implement more tests, particularly checking for error states
27-
- Additional terms may be useful to add to the likelihood
2824
"""
2925

3026
import numpy as np

src/ctapipe/io/simteleventsource.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -637,10 +637,7 @@ def prepare_subarray_info(self, telescope_descriptions, header):
637637
)
638638
except ValueError:
639639
telescope = unknown_telescope(mirror_area, n_pixels)
640-
641-
# TODO: switch to warning or even an exception once
642-
# we start relying on this.
643-
self.log.debug(
640+
self.log.warning(
644641
"Could not determine telescope from sim_telarray metadata,"
645642
" guessing using builtin lookup-table: %d: %s",
646643
tel_id,

src/ctapipe/reco/hillas_intersection.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
# Licensed under a 3-clause BSD style license - see LICENSE.rst
2-
"""
3-
4-
TODO:
5-
- Speed tests, need to be certain the looping on all telescopes is not killing
6-
performance
7-
- Introduce new weighting schemes
8-
- Make intersect_lines code more readable
9-
2+
"""An alternate implementation of the Hillas line-intersection method that more
3+
closely follows the HESS implementation.
104
"""
115
import itertools
126
import warnings

src/ctapipe/tools/info.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,6 @@ def _info_tools():
140140
print("the following can be executed by typing ctapipe-<toolname>:")
141141
print("")
142142

143-
# TODO: how to get a one-line description or
144-
# full help text from the docstring or ArgumentParser?
145-
# This is the function names, we want the command-line names
146-
# that are defined in setup.py !???
147143
from textwrap import TextWrapper
148144

149145
from ctapipe.tools.utils import get_all_descriptions

src/ctapipe/tools/utils.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@ def get_installed_tools():
5050
"""Get list of installed scripts via ``pkg-resources``.
5151
5252
See https://setuptools.pypa.io/en/latest/pkg_resources.html#convenience-api
53-
54-
TODO: not sure if this will be useful ... maybe to check if the list
55-
of installed packages matches the available scripts somehow?
5653
"""
5754
console_tools = {
5855
ep.name: ep.value

0 commit comments

Comments
 (0)