Fix: missing data-* on <ComboBox /> component (#338)

Author: MrFlashAccount

.changeset/purple-kiwis-exist.md

@@ -0,0 +1,5 @@
+---
+'@cube-dev/ui-kit': patch
+---
+
+Fixed missing data-\* attribiutes on `<Combobox />` component

src/components/pickers/ComboBox/ComboBox.tsx

@@ -191,6 +191,7 @@ export const ComboBox = forwardRef(function ComboBox<T extends object>(
   let { contains } = useFilter({ sensitivity: 'base' });
 
   const comboboxProps = {
+    ...otherProps,
     inputValue: props.inputValue,
     defaultInputValue: props.defaultInputValue,
     defaultItems: props.defaultItems,

src/components/pickers/ComboBox/combobox.test.tsx

@@ -131,4 +131,28 @@ describe('<Combobox />', () => {
     expect(filterFn).toHaveBeenCalled();
     expect(options).toHaveLength(1);
   });
+
+  it('should have qa', () => {
+    const { getByTestId } = renderWithRoot(
+      <ComboBox label="test" qa="test">
+        {items.map((item) => (
+          <ComboBox.Item key={item.key}>{item.children}</ComboBox.Item>
+        ))}
+      </ComboBox>,
+    );
+
+    expect(getByTestId('test')).toBeInTheDocument();
+  });
+
+  it('should have data-qa', () => {
+    const { getByTestId } = renderWithRoot(
+      <ComboBox label="test" data-qa="test">
+        {items.map((item) => (
+          <ComboBox.Item key={item.key}>{item.children}</ComboBox.Item>
+        ))}
+      </ComboBox>,
+    );
+
+    expect(getByTestId('test')).toBeInTheDocument();
+  });
 });

tsconfig.cjs.json

@@ -7,6 +7,7 @@
     "declaration": false
   },
   "exclude": [
+    "src/**/__mocks__/**/*",
     "src/**/*.stories.tsx",
     "src/**/*.stories.ts",
     "src/test/**/*",

tsconfig.es.json

@@ -6,6 +6,7 @@
     "noEmit": false
   },
   "exclude": [
+    "src/**/__mocks__/**/*",
     "src/**/*.stories.tsx",
     "src/**/*.stories.ts",
     "src/test/**/*",