Improve CSV value formatting.

Author: cube2222

octosql/values.go

@@ -424,8 +424,6 @@ func (value Value) append(builder *strings.Builder) {
 }
 
 func (value Value) ToRawGoValue(t Type) interface{} {
-	// TODO: Add complex types.
-	// TODO: Fix union handling.
 	switch value.TypeID {
 	case TypeIDNull:
 		return nil

outputs/formats/csv_format.go

@@ -4,6 +4,9 @@ import (
 	"encoding/csv"
 	"fmt"
 	"io"
+	"strconv"
+	"strings"
+	"time"
 
 	"github.com/cube2222/octosql/octosql"
 	"github.com/cube2222/octosql/physical"
@@ -33,13 +36,36 @@ func (t *CSVFormatter) SetSchema(schema physical.Schema) {
 }
 
 func (t *CSVFormatter) Write(values []octosql.Value) error {
+	var builder strings.Builder
 	row := make([]string, len(values))
 	for i := range values {
-		row[i] = fmt.Sprintf("%v", values[i].ToRawGoValue(t.fields[i].Type))
+		FormatCSVValue(&builder, values[i])
+		row[i] = builder.String()
+		builder.Reset()
 	}
 	return t.writer.Write(row)
 }
 
+func FormatCSVValue(builder *strings.Builder, value octosql.Value) {
+	switch value.TypeID {
+	case octosql.TypeIDNull:
+	case octosql.TypeIDInt:
+		builder.WriteString(strconv.FormatInt(int64(value.Int), 10))
+	case octosql.TypeIDFloat:
+		builder.WriteString(strconv.FormatFloat(value.Float, 'f', -1, 64))
+	case octosql.TypeIDBoolean:
+		builder.WriteString(strconv.FormatBool(value.Boolean))
+	case octosql.TypeIDString:
+		builder.WriteString(value.Str)
+	case octosql.TypeIDTime:
+		builder.WriteString(value.Time.Format(time.RFC3339))
+	case octosql.TypeIDDuration:
+		builder.WriteString(fmt.Sprint(value.Duration))
+	default:
+		panic("invalid value type to print in CSV: " + value.TypeID.String())
+	}
+}
+
 func (t *CSVFormatter) Close() error {
 	t.writer.Flush()
 	return nil

tests/scenarios/outputs/csv/types.err

@@ -0,0 +1,6 @@
+octosql "SELECT 42,
+                42.42, 42.42424242424242, float(42),
+                true, false,
+                null,
+                'test' as hello,
+                INTERVAL 5 HOURS + INTERVAL 32 MINUTES + INTERVAL 42 SECONDS" -ocsv

tests/scenarios/outputs/csv/types.in

@@ -0,0 +1,2 @@
+col_0,col_1,col_2,col_3,col_4,col_5,col_6,hello,col_8
+42,42.42,42.42424242424242,42,true,false,,test,5h32m42s