Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue in StringUtils #361

Open
jkronegg opened this issue Jan 31, 2025 · 2 comments · May be fixed by #372
Open

Performance issue in StringUtils #361

jkronegg opened this issue Jan 31, 2025 · 2 comments · May be fixed by #372
Assignees
@jkronegg
Labels
🐛 bug Defect / Bug

Comments

@jkronegg
Copy link
Contributor

👓 What did you see?

In the Parser.parse() method, 30% to 50% of the elapse time is passed doing String trimming in the StringUtils class, see #351 (comment)

✅ What did you expect to see?

No doubt String trimming is important, but it should not last that long.

📦 Which tool/library version are you using?

OpenJDK21
gherkin 31.0.0 (the main branch)

🔬 How could we reproduce it?

See JMH benchmark code in #351 (comment)

📚 Any additional context?

Identified for #351
@jkronegg jkronegg added the 🐛 bug Defect / Bug label Jan 31, 2025
@jkronegg jkronegg self-assigned this Jan 31, 2025
@mpkorstanje
Copy link
Contributor

Using a regular expression for trim looks very inefficiënt. It will be applied for every character in line.

It might be faster to find the last consecutive whitespace character from the start and end, and then take a substring.

@jkronegg
Copy link
Contributor Author

jkronegg commented Feb 2, 2025

The left trim, right trim and left+right trim operations are used for indentation purposes. Thus, rather than dumbly improving StringUtils, I'm thinking on a specific method which trims and idents at the same time.

This was referenced Feb 6, 2025
Open
Open
jkronegg pushed a commit that referenced this issue Feb 11, 2025
fix: corrected misc performance issues for #361
9a1d709
jkronegg pushed a commit that referenced this issue Feb 11, 2025
fix: improved encoding detection performance for #361
f895ae1
jkronegg pushed a commit that referenced this issue Feb 11, 2025
feat: added release info for #361
17c54fc
@jkronegg jkronegg linked a pull request Feb 11, 2025 that will close this issue
Open
7 tasks
jkronegg pushed a commit that referenced this issue Feb 12, 2025
fix: corrected Parser razor generation for #361
2e7829b
jkronegg pushed a commit that referenced this issue Feb 12, 2025
fix: corrected Parser razor generation (2) for #361
a842703
jkronegg pushed a commit that referenced this issue Feb 12, 2025
fix: corrected Parser razor generation (3) for #361
ffb825c
jkronegg pushed a commit that referenced this issue Feb 12, 2025
fix: corrected Parser razor generation (4) for #361
3ff3ae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkronegg jkronegg

Labels
🐛 bug Defect / Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved parser performance cucumber/gherkin
2 participants
@jkronegg @mpkorstanje