Skip to content

Commit 3aca028

Browse files
committed
chore: move defunct test to its own file
1 parent 1482b4d commit 3aca028

File tree

2 files changed

+0
-53
lines changed

2 files changed

+0
-53
lines changed

contracts/RewardManager.vy

-24
Original file line numberDiff line numberDiff line change
@@ -57,30 +57,6 @@ def send_reward_token(_reward_receiver: address, _amount: uint256, _epoch: uint2
5757
Gauge(_reward_receiver).deposit_reward_token(self.reward_token, _amount, _epoch)
5858

5959

60-
@external
61-
def deposit_send_reward_token(_reward_receiver: address, _amount: uint256, _epoch: uint256 = WEEK):
62-
"""
63-
@notice deposit reward token from sender to contract and then forwarded to gauge
64-
@param _reward_receiver gauges to receiver reward
65-
@param _amount amount of reward token to deposit
66-
@param _epoch The duration the rewards are distributed across in seconds. Between 3 days and a year, week by default
67-
"""
68-
assert msg.sender in self.managers, 'only reward managers can call this function'
69-
assert _reward_receiver in self.reward_receivers, 'only reward receiver which are allowed'
70-
assert 3 * WEEK / 7 <= _epoch and _epoch <= WEEK * 4 * 12, 'epoch duration must be between 3 days and a year'
71-
72-
# deposit reward token from sender to this contract
73-
assert ERC20(self.reward_token).transferFrom(msg.sender, self, _amount, default_return_value=True)
74-
75-
assert ERC20(self.reward_token).approve(_reward_receiver, _amount, default_return_value=True)
76-
77-
# legacy gauges have no epoch parameter
78-
# new deposit_reward_token has epoch parameter default to WEEK
79-
if _epoch == WEEK:
80-
LegacyGauge(_reward_receiver).deposit_reward_token(self.reward_token, _amount)
81-
else:
82-
Gauge(_reward_receiver).deposit_reward_token(self.reward_token, _amount, _epoch)
83-
8460
@external
8561
def recover_token(_token: address, _amount: uint256):
8662
"""

tests/RewardManager/test_deposit_reward.py

-29
Original file line numberDiff line numberDiff line change
@@ -44,23 +44,6 @@ def test_reward_manager_send_reward_token_epoch(alice, bob, diana, reward_token,
4444
assert amount == balance_recoverd
4545
assert amount == reward_manager_balance
4646

47-
def test_reward_manager_deposit_simple(bob, recovery_gauge, reward_manager):
48-
reward_manager.deposit_send_reward_token(recovery_gauge, 10 ** 18, sender=bob)
49-
50-
def test_reward_manager_deposit_token(alice, bob, diana, reward_token, recovery_gauge, reward_manager):
51-
amount = 10 ** 17
52-
reward_manager.deposit_send_reward_token(recovery_gauge, amount, sender=bob)
53-
assert recovery_gauge.recover_token(sender=alice)
54-
balance_recoverd = reward_token.balanceOf(diana, sender=alice)
55-
assert amount == balance_recoverd
56-
57-
def test_reward_manager_deposit_epoch(alice, bob, diana, reward_token, recovery_gauge, reward_manager):
58-
amount = 10 ** 17
59-
reward_manager.deposit_send_reward_token(recovery_gauge, amount, 8 * DAY, sender=bob)
60-
assert recovery_gauge.recover_token(sender=alice)
61-
balance_recoverd = reward_token.balanceOf(diana, sender=alice)
62-
assert amount == balance_recoverd
63-
6447
def test_reward_manager_sent_revert(alice, recovery_gauge, reward_manager):
6548
with ape.reverts("only reward managers can call this function"):
6649
reward_manager.send_reward_token(recovery_gauge, 10 ** 18, sender=alice)
@@ -73,18 +56,6 @@ def test_reward_manager_epoch_revert_too_long(bob, recovery_gauge, reward_manage
7356
with ape.reverts("epoch duration must be between 3 days and a year"):
7457
reward_manager.send_reward_token(recovery_gauge, 10 ** 18, 53 * WEEK, sender=bob)
7558

76-
def test_reward_manager_deposit_sent_revert(alice, recovery_gauge, reward_manager):
77-
with ape.reverts("only reward managers can call this function"):
78-
reward_manager.deposit_send_reward_token(recovery_gauge, 10 ** 18, sender=alice)
79-
80-
def test_reward_manager_deposit_epoch_revert_too_short(bob, recovery_gauge, reward_manager):
81-
with ape.reverts("epoch duration must be between 3 days and a year"):
82-
reward_manager.deposit_send_reward_token(recovery_gauge, 10 ** 18, DAY, sender=bob)
83-
84-
def test_reward_manager_deposit_epoch_revert_too_long(bob, recovery_gauge, reward_manager):
85-
with ape.reverts("epoch duration must be between 3 days and a year"):
86-
reward_manager.deposit_send_reward_token(recovery_gauge, 10 ** 18, 53 * WEEK, sender=bob)
87-
8859
def test_recover_token(bob, charlie, diana, lost_token, reward_manager):
8960
amount = 10 ** 18
9061
lost_token.transferFrom(charlie, reward_manager, amount, sender=charlie)

0 commit comments

Comments
 (0)