Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Wayland popups/menus are not handled. #4

Open
arpio23 opened this issue Jan 22, 2024 · 2 comments
Open

Multiple Wayland popups/menus are not handled. #4

arpio23 opened this issue Jan 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@arpio23
Copy link
Contributor

arpio23 commented Jan 22, 2024

If there a menu which opens more then one popup only the first one is handled. With the second one the parent window is not drawn anymore.

Start chromium "Menu->New Tab" works fine. But "Menu->History" while you see the new "History" popup but parent window and parent popup are not rendered.

@erikinkinen erikinkinen changed the title Popups/Menus not handled. Multiple Wayland popups/menus are not handled. Jan 23, 2024
@erikinkinen erikinkinen moved this to Todo in The Board Jan 23, 2024
@erikinkinen erikinkinen added the bug Something isn't working label Jan 23, 2024
@arpio23 arpio23 moved this from Todo to In Progress in The Board Mar 14, 2024
@arpio23
Copy link
Contributor Author

arpio23 commented Mar 14, 2024

This branch is WIP, need to handle the position of pupups. Tested with VLC.
https://github.com/cutie-shell/cutie-wlc/tree/feature/trixie/tl-popup

ed48b56 this fixes most or actually all of the issues with menus/popup. Tested with VLC and Dolphin.

But, GTK (Tested: gnome-console, epiphany, dconf-editor) has that annoying shadow on their windows and I cant see where to get the width of that. So those popups are little offset.

Another issue with GTK, it does not destroy the popup but expects that to be handled by the compositor. Qt unfortunately does not implement that function yet and its not in the dev branch of qt either. Not sure what to do with that.
virtual void QWaylandXdgPopupPrivate::xdg_popup_destroy(QtWaylandServer::xdg_popup::Resource*) Not implemented
That issue leads to the app crashing with error in client communication (pid 22758) after you try to open menu/popup second time.

Imo we can close that issue and #3
@erikinkinen ?

@arpio23
Copy link
Contributor Author

arpio23 commented Mar 20, 2024

@erikinkinen As mentioned in #3 we can close #3

But for this one we need a solution for GTK shadows and virtual void QWaylandXdgPopupPrivate::xdg_popup_destroy(QtWaylandServer::xdg_popup::Resource*) Not implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants