You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, all of the flux and source classes provide Jacobians with respect to the primitive variables only, which is fine for dual time-stepping (dual_time = True), but is not okay for normal time integration (dual_time = False). The current solution is to simply right multiply the primitive flux and source Jacobians by Gamma inverse, but this is not exact in the discrete setting. Thus, routines for calculating the flux and source Jacobians with respect to the conservative variables need to be added, and calc_res_jacob() needs to be updated accordingly.
The text was updated successfully, but these errors were encountered:
Right now, all of the flux and source classes provide Jacobians with respect to the primitive variables only, which is fine for dual time-stepping (
dual_time = True
), but is not okay for normal time integration (dual_time = False
). The current solution is to simply right multiply the primitive flux and source Jacobians by Gamma inverse, but this is not exact in the discrete setting. Thus, routines for calculating the flux and source Jacobians with respect to the conservative variables need to be added, andcalc_res_jacob()
needs to be updated accordingly.The text was updated successfully, but these errors were encountered: