Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux and source Jacobians w/r/t conservative variables #31

Open
cwentland0 opened this issue Apr 15, 2021 · 0 comments
Open

Flux and source Jacobians w/r/t conservative variables #31

cwentland0 opened this issue Apr 15, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@cwentland0
Copy link
Owner

Right now, all of the flux and source classes provide Jacobians with respect to the primitive variables only, which is fine for dual time-stepping (dual_time = True), but is not okay for normal time integration (dual_time = False). The current solution is to simply right multiply the primitive flux and source Jacobians by Gamma inverse, but this is not exact in the discrete setting. Thus, routines for calculating the flux and source Jacobians with respect to the conservative variables need to be added, and calc_res_jacob() needs to be updated accordingly.

@cwentland0 cwentland0 added the enhancement New feature or request label Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant