Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize enthalpy energy/temperature calcs in calc_state_from_cons/prim() to each GasModel #39

Closed
cwentland0 opened this issue Apr 15, 2021 · 0 comments · Fixed by #53
Labels
enhancement New feature or request

Comments

@cwentland0
Copy link
Owner

Right now, calc_state_from_cons() and calc_state_from_prim() are very specific to the CaloricallyPerfectGas model, particularly the stagnation enthalpy calculations implicit in the energy and temperature calculations. This should be generalized to a given gas model, as this is very different for the upcoming TPG model (#18).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant