Open
Description
A new .names
parameter was added to dm_from_con()
in v1.0.6 (#1790) - but it's currently ignored when learn_keys = TRUE
and the subsequent key-querying is successful.
That's because dm_from_con()
returns early if key-querying, via dm_learn_from_db()
, succeeds.
Helpfully, dm_learn_from_db()
already accepts a names_pattern
argument, which is used to format the table names with {glue} in the same way as elsewhere - but we don't pass .names
through to it in dm_from_con()
:
Line 71 in e52ba91
For what it's worth, if key-querying fails, then later in dm_from_con()
we do pass .names
through to get_src_tbl_names()
:
Line 107 in e52ba91
Metadata
Metadata
Assignees
Labels
No labels