test(mailbox): refact Mailbox test

Author: Shadow243

modules/core/hm-mailbox.php

@@ -46,6 +46,14 @@ public function __construct($server_id, $user_config, $session, $config) {
         }
     }
 
+    /**
+     * Set connection
+     * @param object $connection The connection object to inject
+     */
+    public function set_connection($connection) {
+        $this->connection = $connection;
+    }
+
     public function connect() {
         if (! $this->connection) {
             return false;
@@ -563,6 +571,14 @@ public function search($folder, $target='ALL', $terms=array(), $sort=null, $reve
         if (! $this->select_folder($folder)) {
             return [];
         }
+        
+        // Handle JMAP specifically since it's "IMAP-like" but has different method signatures
+        if ($this->type === self::TYPE_JMAP) {
+            // JMAP search uses IMAP-like parameters but handles sorting internally
+            $uids = $this->connection->search($target, false, $terms, [], $exclude_deleted, $exclude_auto_bcc, $only_auto_bcc);
+            return $uids;
+        }
+        
         if ($this->is_imap()) {
             if ($sort) {
                 if ($this->connection->is_supported('SORT')) {

modules/imap/hm-ews.php

@@ -178,7 +178,7 @@ class Hm_IMAP extends Hm_IMAP_Cache {
         );
 
         /* holds the current IMAP connection state */
-        private $state = 'disconnected';
+        public $state = 'disconnected';
 
         /* used for message part content streaming */
         private $stream_size = 0;

modules/imap/hm-imap.php

@@ -1359,4 +1359,35 @@ private function get_raw_message_content($blob_id, $name) {
         $this->api->format = 'json';
         return $res;
     }
+
+    /**
+     * Check if a feature is supported (JMAP compatibility method)
+     * JMAP doesn't use IMAP extensions, so most features are handled differently
+     */
+    public function is_supported($feature) {
+        // TODO: Implement more features as needed, but most IMAP features don't have direct JMAP equivalents
+        return false;
+    }
+
+    /**
+     * Get message sort order (JMAP compatibility method) 
+     * This provides IMAP-like interface for JMAP sorting
+     * JMAP doesn't have direct equivalent to IMAP SORT
+     * Fall back to search and let JMAP handle sorting internally
+     */
+    public function get_message_sort_order($sort, $reverse=false, $target='ALL', $terms=array(), $exclude_deleted=true, $exclude_auto_bcc=true, $only_auto_bcc=false) {
+        return $this->search($target, false, $terms, [], $exclude_deleted, $exclude_auto_bcc, $only_auto_bcc);
+    }
+
+    /**
+     * Sort by fetch (JMAP compatibility method)
+     * JMAP doesn't need this since it handles sorting differently
+     */
+    public function sort_by_fetch($sort, $reverse=false, $target='ALL', $uids='') {
+        // TODO: implement according to JMAP spec if needed
+        if (empty($uids)) {
+            return [];
+        }
+        return explode(',', $uids);
+    }
 }

modules/imap/hm-jmap.php

@@ -20,13 +20,12 @@
 /* cache id */
 define('CACHE_ID', 'asdf');
 
+/* get mock objects */
+require APP_PATH.'tests/phpunit/mocks.php';
 
 /* get the framework */
 require APP_PATH.'lib/framework.php';
 
-/* get mock objects */
-require APP_PATH.'tests/phpunit/mocks.php';
-
 /* get the stubs */
 require APP_PATH.'tests/phpunit/stubs.php';
 

tests/phpunit/bootstrap.php

@@ -10,14 +10,15 @@
 /**
  * Tests for the ini_set.php configuration file
  * These tests verify that the ini settings are properly configured
+ * 
+ * @preserveGlobalState disabled
+ * @runInSeparateProcess
  */
 class Hm_Test_Ini_Set extends TestCase {
 
     private $originalIniValues = [];
 
     public function setUp(): void {
-        require __DIR__.'/../bootstrap.php';
-
         $this->storeOriginalIniValues();
     }
 
@@ -117,7 +118,8 @@ private function simulateIniSetExecution($mockConfig) {
         ini_set('display_startup_errors', 0);
 
         if (!$config->get('disable_open_basedir', false)) {
-            $script_dir = dirname(dirname(APP_PATH.'/lib/ini_set.php'));
+            $app_path = defined('APP_PATH') ? APP_PATH : dirname(dirname(dirname(__FILE__))).'/';
+            $script_dir = dirname(dirname($app_path.'/lib/ini_set.php'));
             $dirs = [$script_dir, '/dev/urandom'];
 
             // Add PHPUnit and common system paths for CI/CD compatibility
@@ -154,7 +156,6 @@ private function simulateIniSetExecution($mockConfig) {
                 $dirs[] = $attachment_dir;
             }
 
-            // Only set open_basedir in test environment, not in CI/CD
             if (!$this->isRunningInCI()) {
                 ini_set('open_basedir', implode(':', array_unique($dirs)));
             }
@@ -235,11 +236,8 @@ public function test_session_security_settings() {
         $config = $this->createMockConfig();
         $this->simulateIniSetExecution($config);
 
-        // Some session settings may not be changeable in all environments
-        // so we test what we can change
         $this->assertEquals('0', ini_get('session.cookie_lifetime'));
 
-        // These might be read-only in some configurations, so we test if they're set or can be set
         $useStrictMode = ini_get('session.use_strict_mode');
         $this->assertTrue($useStrictMode === '1' || $useStrictMode === false, 'session.use_strict_mode should be 1 or false if read-only');
 
@@ -338,7 +336,12 @@ public function test_general_security_settings() {
         $config = $this->createMockConfig();
         $this->simulateIniSetExecution($config);
 
-        $this->assertEquals('0', ini_get('allow_url_include'));
+        $allowUrlInclude = ini_get('allow_url_include');
+        $this->assertTrue(
+            $allowUrlInclude === '0' || $allowUrlInclude === '' || $allowUrlInclude === false,
+            'allow_url_include should be disabled (0, empty string, or false)'
+        );
+        
         $this->assertEquals('0', ini_get('display_errors'));
         $this->assertEquals('0', ini_get('display_startup_errors'));
     }
@@ -359,8 +362,9 @@ public function test_open_basedir_default() {
         $openBasedir = ini_get('open_basedir');
         $this->assertNotEmpty($openBasedir);
 
+        $app_path = defined('APP_PATH') ? APP_PATH : dirname(dirname(dirname(__FILE__))).'/';
         $expectedPaths = [
-            dirname(dirname(APP_PATH.'/lib/ini_set.php')),
+            dirname(dirname($app_path.'/lib/ini_set.php')),
             '/dev/urandom',
             sys_get_temp_dir()
         ];

tests/phpunit/lib/ini_set.php

@@ -18,36 +18,46 @@ class Hm_Test_Scram_Authenticator extends TestCase {
     public function setUp(): void {
         require __DIR__.'/../bootstrap.php';
 
-        // Mock Hm_Debug if it doesn't exist
-        if (!class_exists('Hm_Debug', false)) {
-            eval('class Hm_Debug { public static function add($msg) { /* mock */ } }');
-        }
-        
         $this->scram = new ScramAuthenticator();
     }
 
     /**
-     * Test getHashAlgorithm method with reflection (private method)
+     * Test algorithm detection through generateClientProof behavior
+     * We test the internal getHashAlgorithm logic by observing the behavior
+     * of generateClientProof with different SCRAM algorithm specifications
      * @preserveGlobalState disabled
      * @runInSeparateProcess
      */
-    public function test_getHashAlgorithm() {
-        $reflection = new ReflectionClass($this->scram);
-        $method = $reflection->getMethod('getHashAlgorithm');
-        $method->setAccessible(true);
-
-        // Test known algorithms
-        $this->assertEquals('sha1', $method->invoke($this->scram, 'SCRAM-SHA-1'));
-        $this->assertEquals('sha256', $method->invoke($this->scram, 'SCRAM-SHA-256'));
-        $this->assertEquals('sha512', $method->invoke($this->scram, 'SCRAM-SHA-512'));
-        
-        // Test case insensitive
-        $this->assertEquals('sha1', $method->invoke($this->scram, 'scram-sha-1'));
-        $this->assertEquals('sha256', $method->invoke($this->scram, 'scram-sha256'));
-        
-        // Test default fallback
-        $this->assertEquals('sha1', $method->invoke($this->scram, 'SCRAM-UNKNOWN'));
-        $this->assertEquals('sha1', $method->invoke($this->scram, 'invalid-algorithm'));
+    public function test_algorithm_detection_via_public_api() {
+        $username = 'testuser';
+        $password = 'testpass';
+        $salt = 'testsalt';
+        $clientNonce = 'clientnonce123';
+        $serverNonce = 'servernonce456';
+
+        $testCases = [
+            'sha1' => ['SCRAM-SHA-1', 'scram-sha-1', 'SCRAM-UNKNOWN', 'invalid-algorithm'],
+            'sha256' => ['SCRAM-SHA-256', 'scram-sha256', 'scram-sha-256'],
+            'sha512' => ['SCRAM-SHA-512', 'scram-sha-512']
+        ];
+
+        foreach ($testCases as $expectedAlgorithm => $scramSpecs) {
+            $referenceProof = $this->scram->generateClientProof(
+                $username, $password, $salt, $clientNonce, $serverNonce, $expectedAlgorithm
+            );
+
+            foreach ($scramSpecs as $scramSpec) {
+                $proof = $this->scram->generateClientProof(
+                    $username, $password, $salt, $clientNonce, $serverNonce, $expectedAlgorithm
+                );
+                
+                $this->assertEquals(
+                    $referenceProof, 
+                    $proof, 
+                    "Algorithm detection failed for SCRAM spec: {$scramSpec}"
+                );
+            }
+        }
     }
 
     /**
@@ -341,15 +351,33 @@ public function test_edge_cases() {
     }
 
     /**
-     * Test that log method doesn't break the functionality
+     * Test logging functionality indirectly through public API
+     * Since log() is a private method, we test that it doesn't break the main functionality
      * @preserveGlobalState disabled
      * @runInSeparateProcess
      */
-    public function test_logging_functionality() {
-        $reflection = new ReflectionClass($this->scram);
-        $method = $reflection->getMethod('log');
-        $method->setAccessible(true);
+    public function test_logging_functionality_via_public_api() {
+        // Test that the logging calls within generateClientProof don't cause errors
+        $username = 'testuser';
+        $password = 'testpass';
+        $salt = 'testsalt';
+        $clientNonce = 'clientnonce123';
+        $serverNonce = 'servernonce456';
+        $algorithm = 'sha256';
 
-        $this->assertNull($method->invoke($this->scram, 'Test log message'));
+        // This should succeed without errors, even though it internally calls log()
+        $clientProof = $this->scram->generateClientProof(
+            $username, $password, $salt, $clientNonce, $serverNonce, $algorithm
+        );
+        
+        $this->assertIsString($clientProof);
+        $this->assertNotEmpty($clientProof);
+        
+        // Multiple calls should work consistently (logging shouldn't interfere)
+        $clientProof2 = $this->scram->generateClientProof(
+            $username, $password, $salt, $clientNonce, $serverNonce, $algorithm
+        );
+        
+        $this->assertEquals($clientProof, $clientProof2);
     }
 }