🐛 [Bug] cypht/cypht:v2.5.0 contains script syntax error

[kevinend51]

🐛 Bug

It's shows up Uncaught SyntaxError: Unexpected token '*' for site.js

Version & Environment

Rev: cypht/cypht:v2.5.0

[IrAlfred]

Thank you @kevinend51 for pointing this out, we will look into it.

[indridieinarsson]

I also ran into this. Am running cypht from master (2.5.0 !!! :) ) standalone, through a docker image. Gui is showing up missing most of the components, e.g. the entire toolbar on the left, and the same error message as @kevinend51 reported.

I think this may be caused by the concatenation of 3rd party js components being faulty, probably that code should be adding a newline after adding bootstrap to site.js, and before adding cash to it.

I was able to fix this by adding a newline (an empty line simply) at the beginning of third_party/cash.min.js. This way, the comment at the beginning of cash.min.js starts at a newline in site.js, and the comment becomes valid again.

[kroky]

@Shadow243 this one should fix it but is still in the selenium tests branch: 5becd6a

[Shadow243]

@Shadow243 this one should fix it but is still in the selenium tests branch: 5becd6a

Understood. I will create a PR specifically for that fix.