Skip to content

fix(other): fix some GitHub module issues #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IrAlfred wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −2
Open

fix(other): fix some GitHub module issues #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43bc913
fix(github): handle invalid repository format in all GitHub pages
IrAlfred Oct 12, 2025
e288597
fix(other): handle missing IMAP configuration when using modules such…
IrAlfred Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions modules/github/modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,9 @@ protected function output() {
if (!$this->get('hide_folder_icons')) {
$res .= '<i class="bi bi-code-slash account_icon"></i> ';
}
$res .= $this->html_safe(explode('/', urldecode($repo))[1]).'</a></li>';
$repo_parts = explode('/', urldecode($repo));
$repo_display_name = count($repo_parts) > 1 ? $repo_parts[1] : urldecode($repo);
$res .= $this->html_safe($repo_display_name).'</a></li>';
}
$this->append('folder_sources', array('github_folders', $res));
}
Expand All @@ -463,7 +465,7 @@ protected function output() {
$repo_id = $this->get('github_data_source_id');
$repo = $this->get('github_data_source', 'Github');
$repo_parts = explode('/', $repo);
$repo_name = $repo_parts[1];
$repo_name = count($repo_parts) > 1 ? $repo_parts[1] : $repo;
$cutoff = $this->get('github_list_since', '');
if ($cutoff) {
$cutoff = strtotime($cutoff);
Expand Down
3 changes: 3 additions & 0 deletions modules/imap/handler_modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,6 +1394,9 @@ public function process() {
foreach ($ids as $key => $id) {
$details = Hm_IMAP_List::dump($id);
$mailbox = Hm_IMAP_List::get_connected_mailbox($id, $this->cache);
if (!$mailbox || !$mailbox->authed()) {
Copy link
Member

@kroky kroky Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a mailbox is configured but inaccessible at the moment, we should show an error to the user with details about which mailbox is inaccessible.

continue;
}
if($this->get('list_path') == 'snoozed' && !$mailbox->folder_exists('Snoozed')) {
continue;
}
Expand Down