fix(backend): handle undefined array keys username and password #1805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroky
reviewed
Nov 28, 2025
Baraka24
force-pushed
the
fix-undefined-array-keys
branch
from
60d2454 to
a823f00
Compare
kroky
reviewed
Dec 2, 2025
|
|
||
|
|
||
| $details['password'] = ""; | ||
| $details['username'] = $details['user']; |
Member
There was a problem hiding this comment.
This is still not the correct place to fix it. Here, we are reading already saved details. Who is writing these details and why they are written in this way? You should find out this and fix there...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Issues
Todo