Skip to content

fix(backend): handle undefined array keys username and password #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Baraka24 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(backend): handle undefined array keys username and password #1805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/imap/handler_modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,9 @@ public function process() {
} else {
$folder = hex2bin($parts[2]);
}


$details['password'] = "";
$details['username'] = $details['user'];
Copy link
Member

@kroky kroky Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not the correct place to fix it. Here, we are reading already saved details. Who is writing these details and why they are written in this way? You should find out this and fix there...

$mailbox = Hm_IMAP_List::get_mailbox_without_connection($details);
$label = $mailbox->get_folder_name($folder);
if(!$label) {
Expand Down