Skip to content

Conversation

@AtofStryker
Copy link
Contributor

uses new npm context to more easily adhere to token rotation

@AtofStryker AtofStryker self-assigned this Oct 28, 2025
@netlify
Copy link

netlify bot commented Oct 28, 2025

Deploy Preview for cypress-example-kitchensink ready!

Name Link
🔨 Latest commit 582f7b4
🔍 Latest deploy log https://app.netlify.com/projects/cypress-example-kitchensink/deploys/6900fa46d5ce5f0008a45553
😎 Deploy Preview https://deploy-preview-998--cypress-example-kitchensink.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cypress
Copy link

cypress bot commented Oct 28, 2025

cypress-example-kitchensink    Run #31313

Run Properties:  status check passed Passed #31313  •  git commit 582f7b4b37: chore: use npm credentials context
Project cypress-example-kitchensink
Branch Review chore/use_npm_creds_context
Run status status check passed Passed #31313
Run duration 06m 33s
Commit git commit 582f7b4b37: chore: use npm credentials context
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 123
View all changes introduced in this branch ↗︎
UI Coverage  29.29%
  Untested elements 27  
  Tested elements 35  
Accessibility  90.95%
  Failed rules  5 critical   2 serious   4 moderate   0 minor
  Failed elements 221  

@cypress
Copy link

cypress bot commented Oct 28, 2025

cypress-example-kitchensink    Run #31312

Run Properties:  status check passed Passed #31312  •  git commit 7c84d1a47c ℹ️: Merge 582f7b4b37d24f84cae4b20495e1845f7af9dfc3 into ef8a7c4d0488d953072bcf948bb9...
Project cypress-example-kitchensink
Branch Review chore/use_npm_creds_context
Run status status check passed Passed #31312
Run duration 04m 30s
Commit git commit 7c84d1a47c ℹ️: Merge 582f7b4b37d24f84cae4b20495e1845f7af9dfc3 into ef8a7c4d0488d953072bcf948bb9...
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 123
View all changes introduced in this branch ↗︎
UI Coverage  29.29%
  Untested elements 27  
  Tested elements 35  
Accessibility  90.45%
  Failed rules  5 critical   2 serious   4 moderate   0 minor
  Failed elements 202  

@MikeMcC399
Copy link
Collaborator

@AtofStryker

I couldn't find the reason for the mac-test failure, which is reproducible also in the master branch without the changes in this PR.

I tried bumping the xcode version and separately the resource_class, but nothing helped.

executors:
mac:
macos:
xcode: "16.2.0"
resource_class: macos.m1.medium.gen1

CircleCI is currently going through changes for macOS, including a current brownout, and they may have broken something along the way. It may need a support ticket opening with CircleCI.

Related changes:
https://circleci.com/changelog/macos-default-resource-class-changing-to-m4pro-medium-on-december-3-2025/
https://circleci.com/changelog/deprecation-of-mac-m1-and-m2-resource-classes/

I also tripped up on the fact that the new m4 resources aren't available on free plans (which I use) until Nov 10, 2025.

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Oct 29, 2025

@AtofStryker

Is the Cypress organization intending to use Trusted publishing for npm packages?

According to https://github.com/semantic-release/semantic-release/releases this would require bumping to [email protected], however it doesn't yet seem to be available for CircleCI unless I missed something somewhere.

@AtofStryker
Copy link
Contributor Author

@AtofStryker

Is the Cypress organization intending to use Trusted publishing for npm packages?

According to https://github.com/semantic-release/semantic-release/releases this would require bumping to [email protected], however it doesn't yet seem to be available for CircleCI unless I missed something somewhere.

@MikeMcC399 eventually we would like to migrate to trusted publishing for npm, but as you mentioned it isn't available in circleCI yet. However, we do have several packages that use github actions that could leverage trusted publishing. The goal right now is to migrate to a token that we will rotate in the github repos every X days and create work items to migrate those repos to use trusted publishing as it would be much easier to maintain.

As far as the macOS jobs are concerned, I am going to file an issue as it shouldn't be related to the changes here

@AtofStryker AtofStryker merged commit 39c18ec into master Oct 29, 2025
43 of 44 checks passed
@AtofStryker AtofStryker deleted the chore/use_npm_creds_context branch October 29, 2025 16:21
@MikeMcC399
Copy link
Collaborator

@AtofStryker

As far as the macOS jobs are concerned, I am going to file an issue as it shouldn't be related to the changes here

The issue appears to be that nvm is failing to install an alternate Node.js version. I commented out the nvm instructions to install Node.js 22, and let it use the default Node.js v22.12.0 from the 16.2 xcode image (https://circle-macos-docs.s3.amazonaws.com/image-manifest/v15180/manifest.txt). The mac-test then ran successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants