- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.2k
chore: use npm credentials context #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ✅ Deploy Preview for cypress-example-kitchensink ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| 
  cypress-example-kitchensink 
   | ||||||||||||||||||||||||||||||||||||||||
| Project | cypress-example-kitchensink | 
| Branch Review | chore/use_npm_creds_context | 
| Run status |  | 
| Run duration | 06m 33s | 
| Commit |  | 
| Committer | Bill Glesias | 
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|  | 0 | 
|  | 0 | 
|  | 0 | 
|  | 0 | 
|  | 123 | 
| View all changes introduced in this branch ↗︎ | |
| UI Coverage 29.29% | |
|---|---|
|  | 27 | 
|  | 35 | 
| Accessibility 90.95% | |
|---|---|
|  | 5 critical2 serious4 moderate0 minor | 
|  | 221 | 
| 
  cypress-example-kitchensink 
   | ||||||||||||||||||||||||||||||||||||||||
| Project | cypress-example-kitchensink | 
| Branch Review | chore/use_npm_creds_context | 
| Run status |  | 
| Run duration | 04m 30s | 
| Commit |  | 
| Committer | Bill Glesias | 
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|  | 0 | 
|  | 0 | 
|  | 0 | 
|  | 0 | 
|  | 123 | 
| View all changes introduced in this branch ↗︎ | |
| UI Coverage 29.29% | |
|---|---|
|  | 27 | 
|  | 35 | 
| Accessibility 90.45% | |
|---|---|
|  | 5 critical2 serious4 moderate0 minor | 
|  | 202 | 
| I couldn't find the reason for the mac-test failure, which is reproducible also in the  I tried bumping the  cypress-example-kitchensink/.circleci/config.yml Lines 14 to 18 in ef8a7c4 
 CircleCI is currently going through changes for macOS, including a current brownout, and they may have broken something along the way. It may need a support ticket opening with CircleCI. Related changes: I also tripped up on the fact that the new m4 resources aren't available on free plans (which I use) until Nov 10, 2025. | 
| Is the Cypress organization intending to use Trusted publishing for npm packages? According to https://github.com/semantic-release/semantic-release/releases this would require bumping to [email protected], however it doesn't yet seem to be available for CircleCI unless I missed something somewhere. | 
| 
 @MikeMcC399 eventually we would like to migrate to trusted publishing for npm, but as you mentioned it isn't available in circleCI yet. However, we do have several packages that use github actions that could leverage trusted publishing. The goal right now is to migrate to a token that we will rotate in the github repos every X days and create work items to migrate those repos to use trusted publishing as it would be much easier to maintain. As far as the macOS jobs are concerned, I am going to file an issue as it shouldn't be related to the changes here | 
| 
 The issue appears to be that nvm is failing to install an alternate Node.js version. I commented out the nvm instructions to install Node.js 22, and let it use the default Node.js v22.12.0 from the 16.2 xcode image (https://circle-macos-docs.s3.amazonaws.com/image-manifest/v15180/manifest.txt). The mac-test then ran successfully. | 
uses new npm context to more easily adhere to token rotation