Skip to content

Commit 374ceb2

Browse files
authored
chore: change path created in prevous PR to make windows compliant (#29551)
empty commit to run ci [run ci] squash this
1 parent 2567b72 commit 374ceb2

File tree

4 files changed

+19
-3
lines changed

4 files changed

+19
-3
lines changed

.circleci/workflows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ windowsWorkflowFilters: &windows-workflow-filters
7676
- equal: [ develop, << pipeline.git.branch >> ]
7777
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
7878
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
79-
- equal: [ 'feat/vite_5_support', << pipeline.git.branch >> ]
79+
- equal: [ 'chore/fix_illegal_characters_in_windows', << pipeline.git.branch >> ]
8080
- matches:
8181
pattern: /^release\/\d+\.\d+\.\d+$/
8282
value: << pipeline.git.branch >>

packages/server/test/integration/http_requests_spec.js

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3964,8 +3964,24 @@ describe('Routes', () => {
39643964
})
39653965
})
39663966

3967+
/**
3968+
* NOTE: certain characters cannot be used inside our own monorepo due to our system tests also needing to run
3969+
* inside Windows. The following are reserved characters:
3970+
*
3971+
* < (less than)
3972+
* > (greater than)
3973+
* : (colon)
3974+
* " (double quote)
3975+
* / (forward slash)
3976+
* \ (backslash)
3977+
* | (vertical bar or pipe)
3978+
* ? (question mark)
3979+
* * (asterisk)
3980+
*
3981+
* @see https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions for more details
3982+
*/
39673983
it('can serve files with special characters in the fileServerFolder path', async function () {
3968-
await this.setupProject({ fileServerFolder: `dev/_ :;.,"'!(){}[]@<>=-+*$&\`|~^ĵ符` })
3984+
await this.setupProject({ fileServerFolder: `dev/_ ;.,'!(){}[]@=-+$&\`~^ĵ符` })
39693985

39703986
return this.rp({
39713987
url: `${this.proxy}/foo.txt`,
@@ -3975,7 +3991,7 @@ describe('Routes', () => {
39753991
})
39763992
.then((res) => {
39773993
expect(res.statusCode).to.eq(200)
3978-
expect(res.headers).to.have.property('x-cypress-file-path', encodeURI(`${Fixtures.projectPath('no-server')}/dev/_ :;.,"'!(){}[]@<>=-+*$&\`|~^ĵ符/foo.txt`))
3994+
expect(res.headers).to.have.property('x-cypress-file-path', encodeURI(`${Fixtures.projectPath('no-server')}/dev/_ ;.,'!(){}[]@=-+$&\`~^ĵ符/foo.txt`))
39793995
expect(res.body).to.eq('foo')
39803996
})
39813997
})

0 commit comments

Comments
 (0)