Skip to content

Commit a16edd5

Browse files
authored
chore: move frontend-shared from a dev dependency to a runtime dependency in launchpad package.json (#29783)
* build: move frontend-shared from a dev dependency to a runtime dependency in launchpad package.json * bmp * add darwin workflow * move frontend-shared back to dev dependency in launchpad, declare as nx implicit dep
1 parent 10f90f9 commit a16edd5

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.circleci/cache-version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# Bump this version to force CI to re-create the cache from scratch.
22

3-
06-07-24
3+
07-01-24

.circleci/workflows.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ mainBuildFilters: &mainBuildFilters
3030
- /^release\/\d+\.\d+\.\d+$/
3131
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
3232
- 'update-v8-snapshot-cache-on-develop'
33-
- 'ignore-chrom-prefs'
33+
- 'investigate/darwin-ci-build-order'
3434
- 'publish-binary'
3535
- 'angular-signals-ct-harness'
3636

@@ -44,6 +44,7 @@ macWorkflowFilters: &darwin-workflow-filters
4444
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
4545
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
4646
- equal: [ 'angular-signals-ct-harness', << pipeline.git.branch >> ]
47+
- equal: [ 'investigate/darwin-ci-build-order', << pipeline.git.branch >> ]
4748
- matches:
4849
pattern: /^release\/\d+\.\d+\.\d+$/
4950
value: << pipeline.git.branch >>

packages/launchpad/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@
7575
],
7676
"nx": {
7777
"implicitDependencies": [
78-
"@packages/graphql"
78+
"@packages/graphql",
79+
"@packages/frontend-shared"
7980
]
8081
}
8182
}

0 commit comments

Comments
 (0)