-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Description
Current behavior
If an attempt is made to update playwright-webkit to the latest version in Cypress source code, it fails the Cypress test spec
which is part of driver-integration-tests-webkit.
This is reproducible on Ubuntu with versions of playwright-webkit starting with 1.37.0 and extending to the current version (with WebKit 17.418.026.x).
Cypress is currently configured to use [email protected] released in July 2022:
Line 189 in d8884e0
| "playwright-webkit": "1.24.2", |
Desired behavior
WebKit should pass all tests from driver-integration-tests-webkit when using the latest version of playwright-webkit.
- Qualify if this is due to bug(s) in Playwright/WebKit or Cypress
- Depending on outcome, report bugs to Playwright and / or fix bugs in Cypress
Test code to reproduce
npm install yarn@latest -g
git clone https://github.com/cypress-io/cypress
cd cypress
yarn add playwright-webkit@latest -D -W
yarn playwright install-deps webkit # Linux onlythen
yarn workspace @packages/driver cypress:run --browser webkit --spec cypress/e2e/commands/cookies.cy.jsor
yarn workspace @packages/driver cypress:open --e2e --browser webkitand select cypress/e2e/commands/cookies.cy.js to run in UI.
Playwright Version
First reported on [email protected]
Continues to be reproducible on [email protected]
Cypress Version
First reported on 13.13.2
Continues to be reproducible on 15.0.0
Node version
v18.17.1v20.18.1 and v22.18.0
Operating System
Ubuntu 22.04.4 LTS
Ubuntu 22.04.5 LTS and
Ubuntu 24.04.3 LTS
Debug Logs
See failures in CircleCI at
https://app.circleci.com/pipelines/github/cypress-io/cypress/63152/workflows/e49a5390-7dc4-432e-abce-391b205c080b/jobs/2615104
1) src/cy/commands/cookies - no stub
#getCookies
returns cookies for the specified domain:
AssertionError: expected 'key2' to equal 'key1'
+ expected - actual
-'key2'
+'key1'
at ([native code])
at (http://www.barbaz.com:3500/__cypress/tests:1717:41)
getRet@
tryCatcher@
@
thenFn@
@
tryCatcher@
@
@
@
_drainQueueStep@
_drainQueue@
@
@
2) src/cy/commands/cookies - no stub
#getCookie
returns the cookie from the specified domain:
AssertionError: expected 'foobar.com value' to equal 'www.foobar.com value'
+ expected - actual
-'foobar.com value'
+'www.foobar.com value'
at ([native code])
at (http://www.barbaz.com:3500/__cypress/tests:1870:38)
getRet@
tryCatcher@
@
thenFn@
@
tryCatcher@
@
@
@
_drainQueueStep@
_drainQueue@
@
@
3) src/cy/commands/cookies
#setCookie
can set cookies with sameSite:
AssertionError: expected { Object (name, value, ...) } to have property 'sameSite' of 'no_restriction', but got 'lax'
+ expected - actual
-'lax'
+'no_restriction'
at ([native code])
applyChainer@
arrayReduce@
reduce@
applyChainers@
tryCatcher@
@
shouldFn@
@
tryCatcher@
@
@
@
_drainQueueStep@
_drainQueue@
@
@
Other
- See WebKit (Experimental)
- https://playwright.dev/docs/browsers#webkit
- See chore(webkit): update playwright-webkit to 1.45.3 #29955 for failed attempt to update.