Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to minimum pandas 1.2 and deprecate python 3.5 #56

Open
gwaybio opened this issue May 12, 2021 · 0 comments
Open

Upgrade to minimum pandas 1.2 and deprecate python 3.5 #56

gwaybio opened this issue May 12, 2021 · 0 comments
Labels
question Further information is requested

Comments

@gwaybio
Copy link
Member

gwaybio commented May 12, 2021

At some point in the future, we should consider making the minimum pandas version >=1.2 in the requirements.txt file.

I debated performing this in #55 because of one silly deprecating in pandas.testing.assert_frame_equal (rtol argument, see 03c09ee). However, I decided that this version upgrade and deprecation should probably be thought through in more detail.

One idea is to mirror the version requirements of pycytominer since both of them are likely going to be used together often. We should also think about certain projects that might no longer be able to use cytominer-eval after this decision, although I think that should be a non-issue since those other projects are probably using a specific cytominer-eval hash.

@gwaybio gwaybio added the question Further information is requested label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant