Skip to content

Incompatible with django_celery_results #73

@aidin-leo

Description

@aidin-leo

Websocket breaks when using django celery results because of django ORM.

Activity

aidin-leo

aidin-leo commented on Jan 8, 2021

@aidin-leo
Author

This can be fixed by adding sync_to_async decorator to progress.get_info() or for compatibility to oldest version receive method can be updated to:

async def receive(self, text_data):
    text_data_json = json.loads(text_data)
    task_type = text_data_json['type']

    if task_type == 'check_task_completion':
        from asgiref.sync import sync_to_async
        await self.channel_layer.group_send(
            self.task_id,
            {
                'type': 'update_task_progress',
                'data': await sync_to_async(Progress(AsyncResult(self.task_id)).get_info, thread_sensitive=True)()
            }
        )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @aidin-leo

      Issue actions

        Incompatible with django_celery_results · Issue #73 · czue/celery-progress