Merge pull request #6 from d-oit/test-validation-branch

Test validation PR

Author: d-oit

.github/workflows/auto-fix.yml

@@ -13,7 +13,7 @@ jobs:
   auto-fix:
     name: Auto-fix Formatting and Clippy Issues
     runs-on: ubuntu-latest
-    if: "!contains(github.event.head_commit.message, '[skip auto-fix]')"
+    if: ${{ !contains(github.event.head_commit.message, '[skip auto-fix]') }}
 
     steps:
     - uses: actions/checkout@v4
@@ -27,7 +27,7 @@ jobs:
         components: rustfmt, clippy
 
     - name: Cache cargo registry
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: |
           ~/.cargo/registry
@@ -75,27 +75,33 @@ jobs:
       run: |
         git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
         git config --local user.name "github-actions[bot]"
-        
+
         # Check if there are changes to commit
         if ! git diff --quiet; then
           git add .
-          
+
           # Create detailed commit message
+          FORMAT_NEEDED="${FORMAT_NEEDED_VAR}"
+          CLIPPY_NEEDED="${CLIPPY_NEEDED_VAR}"
           COMMIT_MSG="auto-fix: apply code quality fixes [skip auto-fix]"
-          if [ "${{ steps.check.outputs.format_needed }}" = "true" ]; then
+          if [ "$FORMAT_NEEDED" = "true" ]; then
             COMMIT_MSG="$COMMIT_MSG
 
         - Apply cargo fmt formatting"
-              fi
-              if [ "${{ steps.check.outputs.clippy_needed }}" = "true" ]; then
-                COMMIT_MSG="$COMMIT_MSG
+          fi
+          if [ "$CLIPPY_NEEDED" = "true" ]; then
+            COMMIT_MSG="$COMMIT_MSG
+
         - Apply clippy suggestions"
           fi
-          
+
           git commit -m "$COMMIT_MSG"
           git push
-          
+
           echo "✅ Code quality fixes applied and pushed!"
         else
           echo "ℹ️ No changes were made by the auto-fix tools."
-        fi
+        fi
+      env:
+        FORMAT_NEEDED_VAR: ${{ steps.check.outputs.format_needed }}
+        CLIPPY_NEEDED_VAR: ${{ steps.check.outputs.clippy_needed }}

.github/workflows/ci.yml

@@ -28,48 +28,46 @@ jobs:
     - uses: actions/checkout@v4
 
     - name: Install Rust
-      uses: dtolnay/rust-toolchain@master
+      uses: dtolnay/rust-toolchain@stable
       with:
         toolchain: ${{ matrix.rust }}
         components: rustfmt, clippy
 
     - name: Cache cargo registry
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: |
           ~/.cargo/registry
           ~/.cargo/git
           target
         key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-    
+
     - name: Check formatting
       run: cargo fmt --all -- --check
       continue-on-error: true
       id: fmt-check
-    
+
     - name: Formatting feedback
       if: steps.fmt-check.outcome == 'failure'
       run: |
-        echo "❌ Code formatting issues detected!"
+        echo "::warning::Code formatting issues detected!"
         echo "Please run 'cargo fmt --all' to fix formatting."
         echo "Or add this to your pre-commit hook:"
         echo "  cargo fmt --all"
-        exit 1
-    
+
     - name: Run clippy
       run: cargo clippy --all-targets --all-features -- -D warnings
-      continue-on-error: true  
+      continue-on-error: true
       id: clippy-check
-      
+
     - name: Clippy feedback
       if: steps.clippy-check.outcome == 'failure'
       run: |
-        echo "❌ Clippy issues detected!"
+        echo "::warning::Clippy issues detected!"
         echo "Please run 'cargo clippy --all-targets --all-features --fix --allow-dirty' to fix issues."
         echo "Or add this to your development workflow:"
         echo "  cargo clippy --fix --allow-dirty"
         echo "Or run './scripts/fix-code-quality.sh' to auto-fix both formatting and clippy issues."
-        exit 1
     
     - name: Build
       run: cargo build --verbose
@@ -93,15 +91,24 @@ jobs:
 
     - name: Install cargo-llvm-cov
       uses: taiki-e/install-action@cargo-llvm-cov
-    
+
+    - name: Cache cargo registry
+      uses: actions/cache@v4
+      with:
+        path: |
+          ~/.cargo/registry
+          ~/.cargo/git
+          target
+        key: ${{ runner.os }}-cargo-coverage-${{ hashFiles('**/Cargo.lock') }}
+
     - name: Generate code coverage
-      run: cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info
+      run: cargo llvm-cov --all-features --lcov --output-path lcov.info
+    
     - name: Upload coverage report
       uses: actions/upload-artifact@v4
       with:
         name: coverage-report
         path: lcov.info
-    
 
   security:
     name: Security Audit
@@ -119,6 +126,9 @@ jobs:
     name: Code Review Agent
     runs-on: ubuntu-latest
     if: github.event_name == 'pull_request'
+    permissions:
+      pull-requests: write
+      contents: read
     steps:
     - uses: actions/checkout@v4
 
@@ -132,6 +142,8 @@ jobs:
 
     - name: Comment on PR if issues found
       if: failure()
-      run: gh pr comment ${{ github.event.pull_request.number }} --body "Code review agent detected issues. Please address the clippy warnings."
+      run: |
+        gh pr comment $PR_NUMBER --body "Code review agent detected issues. Please address the clippy warnings."
       env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        PR_NUMBER: ${{ github.event.pull_request.number }}

.github/workflows/docs.yml

@@ -3,6 +3,8 @@ name: Deploy Docs
 on:
   push:
     branches: [ main ]
+  pull_request:
+    branches: [ main ]
   workflow_dispatch:
 
 permissions:
@@ -17,19 +19,20 @@ concurrency:
 jobs:
   build:
     runs-on: ubuntu-latest
+    if: github.event_name != 'pull_request'
     steps:
     - uses: actions/checkout@v4
 
     - name: Install Rust
       uses: dtolnay/rust-toolchain@stable
 
     - name: Cache cargo registry
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: |
           ~/.cargo/registry
           ~/.cargo/git
-        key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
+        key: ${{ runner.os }}-cargo-docs-${{ hashFiles('**/Cargo.lock') }}
 
     - name: Build Documentation
       run: cargo doc --no-deps --workspace --document-private-items
@@ -57,7 +60,7 @@ jobs:
       uses: actions/configure-pages@v4
 
     - name: Upload artifact
-      uses: actions/upload-pages-artifact@v3
+      uses: actions/upload-pages-artifact@v4
       with:
         path: ./target/doc
 
@@ -67,6 +70,7 @@ jobs:
       url: ${{ steps.deployment.outputs.page_url }}
     runs-on: ubuntu-latest
     needs: build
+    if: github.event_name != 'pull_request'
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
@@ -76,6 +80,9 @@ jobs:
     name: Docs Agent
     runs-on: ubuntu-latest
     if: github.event_name == 'pull_request'
+    permissions:
+      pull-requests: write
+      contents: read
     steps:
     - uses: actions/checkout@v4
 
@@ -87,6 +94,8 @@ jobs:
 
     - name: Comment on PR if docs issues
       if: failure()
-      run: gh pr comment ${{ github.event.pull_request.number }} --body "Docs agent detected issues in documentation generation."
+      run: |
+        gh pr comment $PR_NUMBER --body "Docs agent detected issues in documentation generation."
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        PR_NUMBER: ${{ github.event.pull_request.number }}

.github/workflows/monitor.yml

@@ -0,0 +1,83 @@
+name: Monitor Workflows
+
+on:
+  schedule:
+    - cron: '0 0 * * *'  # Daily at midnight UTC
+  workflow_dispatch:  # Allow manual trigger for testing
+
+jobs:
+  monitor:
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+      contents: read
+      actions: read
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: List recent workflow runs
+        run: |
+          # Calculate date 24 hours ago in ISO 8601 format
+          since=$(date -u -d '24 hours ago' +%Y-%m-%dT%H:%M:%SZ)
+          echo "Fetching runs since: $since"
+          
+          # Fetch recent runs with retry logic to handle rate limits
+          max_retries=3
+          retry_count=0
+          while [ $retry_count -lt $max_retries ]; do
+            if gh run list --created ">=$since" --limit 1000 --json number,status,conclusion,workflowName,createdAt,updatedAt > runs.json 2>/dev/null; then
+              break
+            else
+              retry_count=$((retry_count + 1))
+              echo "Retry $retry_count/$max_retries due to potential rate limit or error"
+              sleep 60
+            fi
+          done
+          
+          if [ $retry_count -eq $max_retries ]; then
+            echo "Failed to fetch runs after $max_retries retries"
+            exit 1
+          fi
+
+      - name: Check for failures in monitored workflows
+        run: |
+          # Define monitored workflows (without .yml extension)
+          workflows=("auto-fix" "CI" "docs" "release" "pages")
+          
+          failures=()
+          
+          for wf in "${workflows[@]}"; do
+            # Find failed runs for this workflow
+            failed_runs=$(jq -r ".[] | select(.workflowName == \"$wf\" and .conclusion == \"failure\") | \"Run #\\(.number) (\\(.createdAt))\"" runs.json 2>/dev/null || echo "")
+            
+            if [ -n "$failed_runs" ] && [ "$failed_runs" != "null" ]; then
+              failures+=("$wf workflow failures:")
+              while IFS= read -r run; do
+                failures+=("  - $run")
+              done <<< "$failed_runs"
+              failures+=("")  # Empty line for separation
+            fi
+          done
+          
+          if [ ${#failures[@]} -gt 0 ]; then
+            echo "Failures detected:"
+            printf '%s\n' "${failures[@]}"
+            
+            # Prepare notification content
+            title="Workflow Failures Detected - $(date -u +%Y-%m-%d)"
+            body="The following workflows have failed in the last 24 hours:\n\n$(printf '%s\n' "${failures[@]}")\n\nPlease investigate the failed runs in the Actions tab."
+            
+            # Check for existing open issue with similar title
+            existing_issue=$(gh issue list --label "workflow-failure" --state open --json number,title --limit 10 | jq -r ".[] | select(.title | startswith(\"Workflow Failures Detected\")) | .number" | head -1)
+            
+            if [ -z "$existing_issue" ]; then
+              echo "Creating new issue for workflow failures"
+              gh issue create --title "$title" --body "$body" --label "workflow-failure,bug"
+            else
+              echo "Commenting on existing issue #$existing_issue"
+              gh issue comment "$existing_issue" --body "New failures detected:\n\n$body"
+            fi
+          else
+            echo "No workflow failures detected in the last 24 hours."
+          fi