executor/mail: fix: line breaks in email body are not properly converted to <br /> (#888)

Author: yottahmd

internal/digraph/builder.go

@@ -85,6 +85,7 @@ var stepBuilderRegistry = []stepBuilderEntry{
 	{name: "repeatPolicy", fn: buildRepeatPolicy},
 	{name: "signalOnStop", fn: buildSignalOnStop},
 	{name: "precondition", fn: buildStepPrecondition},
+	{name: "output", fn: buildOutput},
 }
 
 type stepBuilderEntry struct {
@@ -550,7 +551,6 @@ func buildStep(ctx BuildContext, def stepDef, fns []*funcDef) (*Step, error) {
 		Script:         def.Script,
 		Stdout:         def.Stdout,
 		Stderr:         def.Stderr,
-		Output:         def.Output,
 		Dir:            def.Dir,
 		MailOnError:    def.MailOnError,
 		ExecutorConfig: ExecutorConfig{Config: make(map[string]any)},
@@ -625,6 +625,20 @@ func buildRepeatPolicy(_ BuildContext, def stepDef, step *Step) error {
 	return nil
 }
 
+func buildOutput(_ BuildContext, def stepDef, step *Step) error {
+	if def.Output == "" {
+		return nil
+	}
+
+	if strings.HasPrefix(def.Output, "$") {
+		step.Output = strings.TrimPrefix(def.Output, "$")
+		return nil
+	}
+
+	step.Output = def.Output
+	return nil
+}
+
 func buildStepPrecondition(ctx BuildContext, def stepDef, step *Step) error {
 	// Parse both `preconditions` and `precondition` fields.
 	conditions, err := parsePrecondition(ctx, def.Preconditions)

internal/mailer/mailer.go

@@ -157,7 +157,7 @@ func joinBytes(s ...[]byte) []byte {
 
 func newlineToBrTag(body string) string {
 	return strings.NewReplacer(
-		`\r\n`, "<br />", `\r`, "<br />", `\n`, "<br />",
+		`\r\n`, "<br />", `\r`, "<br />", `\n`, "<br />", "\r\n", "<br />", "\r", "<br />", "\n", "<br />",
 	).Replace(body)
 }
 

schemas/dag.schema.json

@@ -34,7 +34,6 @@
     },
     "schedule": {
       "type": "string",
-      "pattern": "(\\*|[0-5]?[0-9]|\\*/[0-9]+)\\s+(\\*|1?[0-9]|2[0-3]|\\*/[0-9]+)\\s+(\\*|[1-2]?[0-9]|3[0-1]|\\*/[0-9]+)\\s+(\\*|[0-9]|1[0-2]|\\*/[0-9]+|jan|feb|mar|apr|may|jun|jul|aug|sep|oct|nov|dec)\\s+(\\*/[0-9]+|\\*|[0-7]|sun|mon|tue|wed|thu|fri|sat)\\s*(\\*/[0-9]+|\\*|[0-9]+)?",
       "description": "Cron expression that determines how often the DAG runs (e.g., '5 4 * * *' runs daily at 04:05). If omitted, the DAG will only run manually."
     },
     "skipIfSuccessful": {