Click a not existing element in the page doesn't fail the build

[cedmax]

I tried it with

    .waitForElement('a.vd-box')
        .assert.attr('a.vd-box', 'href', 'http://www.youtube.com/watch?v=' + video)
    .click('a.NOT_EXISTING_CLASS')
    .waitForElementPresent('iframe.mfp-iframe')
        .assert.attr('iframe.mfp-iframe', 'src', 'http://www.youtube.com/embed/'+video+'?autoplay=1&iv_load_policy=3')
    .done();
    }

and the build succeeds.

I would expect an error raised for the missing element, instead there is a silent error and the following waitForElementPresent fails to get executed.

DalekJS CLI Tools Version: 0.0.4
DalekJS local install: 0.0.8

on PhantomJS 1.9.7 / Mac OSx 10.9.2

[asciidisco]

Mhh.

If you do an test.assert.exists('a.NOT_EXISTING_CLASS') your build will fail; but I agree that at least a warning should be shown, that no matching elements could be found.

Cheers

[cedmax]

The point, imho, is I might either have mispelled the classname or give for granted that is there.
The silent failure could be harmful. Unless I can declare the number of expected assertions, but I didn't find it in the docs (if it is there I apologize)

[asciidisco]

There is, but no need to apologize, because it isn't documented ;)
You can add a test.expect(5) to the top of your test to check for the correct amount of assertions.
Still, it is a valid question if the runner should fail or not in such cases.

[mdix]

Hi,

IMHO it should fail.

I just add a call to click() to my tests if I expect the item that shall be clicked to be existent. If it is not, I want to know that, because I could've:

• misspelled the selector (as cedmax stated)
• broke my markup / scripts

I also don't want to add a call to exists() above every call to click(). This would just be impractical.

Best
Marc