Skip to content

Online update for macOS #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

DirkMausF
Copy link

@DirkMausF DirkMausF commented May 8, 2025

Changes to download the latest macos_build.zip from Github and exchange it with the Application that has started the update.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need changes in this file?

ext/zlib/zutil.c Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it unrelated

@@ -225,7 +225,11 @@ static void add_definition(const hotkey_mapping& mapping, bool alt) {
def->callback = [] { events::emit(event_building_mode{ BUILDING_GRANARY }); };
break;

case BUILDING_STORAGE_YARD:
/*case BUILDING_STORAGE_YARD:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it's unrelated, I changed that a while ago and forgot to take it out when committing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget, I'm new to this Github-PullRequest-Commit-thing... Sorry.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np, its ok

@@ -4,9 +4,6 @@
*/

#include "zutil.h"
#ifndef Z_SOLO
# include "gzguts.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants