Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect bitcoin cash address being generated by CashAddress class #44

Open
ynohtna92 opened this issue Aug 15, 2021 · 0 comments
Open

Incorrect bitcoin cash address being generated by CashAddress class #44

ynohtna92 opened this issue Aug 15, 2021 · 0 comments

Comments

@ynohtna92
Copy link

The current CashAddress.php file is generating incorrect cash addresses.

Running CashAddress::old2new('13spvtVJmRkTWGTCC8ya4LpQguCni9pHZE') currently gives bitcoincash:qq0c6rc3pf0hpf0r0849ddg36y9235e83sqqndxum7 (which doesn't pass a checksum), instead of bitcoincash:qq0c6rc3pf0hpf0r0849ddg36y9235e83s5wh0n72c.

Please update CashAddress.php to the newest version https://github.com/Har01d/CashAddressPHP as I have tested the class and it correctly converts the old address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ynohtna92