You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
On the link component textAnchor is used as a style property like so: <text style={{ textAnchor: "middle" }} {...textProps}> but textProps contains style and thus overwrites the style property for textAnchor.
Change the link config to enable renderLabel and change labelProperty to source
See the labels are not centered as expected.
Expected behavior
Expected the label to be centered. Its not because the style usage of textAnchor is ignored.
Screenshots
Image showing the settings to change
Image showing the labels not centered
Environment:
react-d3-graph version 2.6.0
Additional context
None
The text was updated successfully, but these errors were encountered:
facultymatt
changed the title
Link label is not positioned correctly due to element attr incorrectly being used as style property
Link label is not positioned correctly
Jan 6, 2021
Describe the bug
On the link component
textAnchor
is used as a style property like so:<text style={{ textAnchor: "middle" }} {...textProps}>
buttextProps
containsstyle
and thus overwrites thestyle
property fortextAnchor
.react-d3-graph/src/components/link/Link.jsx
Lines 96 to 103 in 0ac8c47
Here
style
gets overwritten bytextProps.style
react-d3-graph/src/components/link/Link.jsx
Line 109 in 0ac8c47
There are two ways to make this work as expected, one is to use
text-anchor
as an attr. See the docs here: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/text-anchorSecond is to include it in the style object above, so you'd have
To Reproduce
Steps to reproduce the behavior:
renderLabel
and changelabelProperty
tosource
Expected behavior
Expected the label to be centered. Its not because the style usage of
textAnchor
is ignored.Screenshots
Image showing the settings to change
Image showing the labels not centered

Environment:
Additional context
None
The text was updated successfully, but these errors were encountered: