Accept DateTimeOffset for workflow start time #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds overload to DaprWorkflowClient.ScheduleNewWorkflowAsync accepting a DateTimeOffset? value for startTime - Resolves dapr#1576 Signed-off-by: Frank Buckley <[email protected]>
|
Will revisit |
Signed-off-by: Frank Buckley <[email protected]>
|
Requiring the parameters on the new overload raises the question again of whether to replace the DateTime? on the existing overload. It is a binary breaking change, but on recompilation there will be a default conversion to DateTimeOffset (as happens now under the covers). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds overload to
DaprWorkflowClient.ScheduleNewWorkflowAsyncaccepting aDateTimeOffset?value forstartTime.Note: I have included the documentation change from #1581 and also included it on the new overload.
Issue reference
#1576
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: