Skip to content

chore: Support taskExecutionId #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

javier-aliaga
Copy link
Contributor

@javier-aliaga javier-aliaga commented Jun 20, 2025

Description

Support new field taskExecutionId

Implements:

Depends on:

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@javier-aliaga javier-aliaga requested review from a team as code owners June 20, 2025 08:38
@mikeee mikeee marked this pull request as draft June 20, 2025 10:11
@mikeee
Copy link
Member

mikeee commented Jun 20, 2025

Drafting this until the upstream changes are merged and the deps vendored

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.11%. Comparing base (6c59092) to head (570cb3b).
Report is 26 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (6c59092) and HEAD (570cb3b). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (6c59092) HEAD (570cb3b)
4 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   62.52%   57.11%   -5.42%     
==========================================
  Files          56       58       +2     
  Lines        4139     4349     +210     
==========================================
- Hits         2588     2484     -104     
- Misses       1425     1736     +311     
- Partials      126      129       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@javier-aliaga javier-aliaga force-pushed the execution-task-id branch 4 times, most recently from 2c78378 to b5283c5 Compare July 7, 2025 08:36
@javier-aliaga javier-aliaga reopened this Jul 7, 2025
@javier-aliaga javier-aliaga marked this pull request as ready for review July 14, 2025 09:00
@javier-aliaga
Copy link
Contributor Author

javier-aliaga commented Jul 14, 2025

Why codecov/project is failing? It is comparing with a very old commit (6c59092). Where is it configured?

@javier-aliaga javier-aliaga marked this pull request as draft July 14, 2025 09:32
@mikeee
Copy link
Member

mikeee commented Jul 14, 2025

I wouldn't worry too much about the pretty arbitary codecov, I can see the config hasn't been updated for 5 years in the root of the repo.

Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants