-
Notifications
You must be signed in to change notification settings - Fork 183
chore: Support taskExecutionId #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Drafting this until the upstream changes are merged and the deps vendored |
1627eee
to
60d9c76
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
- Coverage 62.52% 57.11% -5.42%
==========================================
Files 56 58 +2
Lines 4139 4349 +210
==========================================
- Hits 2588 2484 -104
- Misses 1425 1736 +311
- Partials 126 129 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2c78378
to
b5283c5
Compare
Why codecov/project is failing? It is comparing with a very old commit (6c59092). Where is it configured? |
41731b7
to
570cb3b
Compare
I wouldn't worry too much about the pretty arbitary codecov, I can see the config hasn't been updated for 5 years in the root of the repo. |
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
570cb3b
to
a0e0f8b
Compare
Description
Support new field taskExecutionId
Implements:
Depends on:
Issue reference
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: