Skip to content

Richer E2E Tests demonstrating WorkflowRuntimeStatus #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TonyPythoneer opened this issue Feb 11, 2025 · 0 comments
Open

Richer E2E Tests demonstrating WorkflowRuntimeStatus #660

TonyPythoneer opened this issue Feb 11, 2025 · 0 comments

Comments

@TonyPythoneer
Copy link

Description:
I’d like to request more end-to-end (E2E) tests to validate how DaprWorkflowClient retrieves the expected WorkflowRuntimeStatus from Dapr when running a workflow instance. Clear examples would help ensure users understand the expected status transitions in different scenarios.

For example, it would be helpful to see a test demonstrating how DaprWorkflowClient interacts with workflow states:

const workflowClient = new DaprWorkflowClient();
await workflowClient.terminateWorkflow(id, "some reason for termination");
const state = await getWorkflowState(id, false);
expect(state?.runtimeStatus).toEqual(WorkflowRuntimeStatus.TERMINATED);

Request for Enhancement:

Could additional E2E tests be added to cover different workflow scenarios and validate WorkflowRuntimeStatus? These tests would clarify when specific statuses are triggered and improve developer confidence in using the SDK.

WorkflowRuntimeStatus Values to Cover:

  1. RUNNING – The workflow is actively executing.
  2. COMPLETED – The workflow has finished successfully.
  3. FAILED – The workflow encountered an error and failed.
  4. TERMINATED – The workflow was forcefully stopped before completion.
  5. CONTINUED_AS_NEW – The workflow instance has completed but started a new instance as a continuation.
  6. PENDING – The workflow is scheduled but has not started yet.
  7. SUSPENDED – The workflow is paused and waiting to be resumed.

These tests would help ensure that DaprWorkflowClient correctly reflects workflow runtime statuses under different conditions.

Thanks for your consideration! 🚀

@WhitWaldo WhitWaldo changed the title Request for Additional E2E Tests on WorkflowRuntimeStatus in Dapr JS SDK Richer E2E Tests demonstrating WorkflowRuntimeStatus Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants