Make NLS support mandatory

Author: victoryforce

CMakeLists.txt

@@ -396,15 +396,12 @@ endif(USE_XMLLINT)
 message(STATUS "All external programs found")
 
 # The path can be modified by setting CMAKE_INSTALL_LOCALEDIR
-if(USE_NLS)
-    find_package(Gettext)
-    if(GETTEXT_MSGFMT_EXECUTABLE)
-        message(STATUS "Found msgfmt to convert .po file. Translation enabled")
-        add_subdirectory(po)
-    else()
-        message(STATUS "Cannot find msgfmt to convert .po file. Translation won't be enabled")
-    endif()
-endif(USE_NLS)
+find_package(Gettext REQUIRED)
+if(GETTEXT_MSGFMT_EXECUTABLE)
+    add_subdirectory(po)
+else()
+    message(FATAL_ERROR "ERROR: Cannot find msgfmt to convert .po file")
+endif()
 
 # needed to generate file "preferences_gen.h" accordingly
 if(USE_OPENCL)

DefineOptions.cmake

@@ -1,5 +1,4 @@
 option(USE_CAMERA_SUPPORT "Detect and use camera support if available." ON)
-option(USE_NLS "Build Native Language Support (using gettext)" ON)
 option(USE_COLORD "Enable colord support" ON)
 option(USE_MAP "Build Map View parts" ON)
 option(USE_LUA "Build lua scripting support" ON)

build.sh

@@ -35,7 +35,7 @@ CMAKE_OPTIONS_FROM_CMDLINE=""
 
 PRINT_HELP=0
 
-FEATURES="CAMERA COLORD GRAPHICSMAGICK IMAGEMAGICK JXL KWALLET LIBSECRET LUA MAC_INTEGRATION MAP NLS OPENCL OPENEXR OPENMP UNITY WEBP"
+FEATURES="CAMERA COLORD GRAPHICSMAGICK IMAGEMAGICK JXL KWALLET LIBSECRET LUA MAC_INTEGRATION MAP OPENCL OPENEXR OPENMP UNITY WEBP"
 
 # prepare a lowercase version with a space before and after
 # it's very important for parse_feature, has no impact in for loop expansions