Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose filesystem of the machine that deploys dart-services #2157

Closed
johnpryan opened this issue Jan 27, 2022 · 4 comments
Closed

Don't expose filesystem of the machine that deploys dart-services #2157

johnpryan opened this issue Jan 27, 2022 · 4 comments
Labels
area-dart-services area-error-messaging closed-duplicate Closed in favor of an existing report P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@johnpryan
Copy link
Contributor

The JS console reveals filesystem details:

errors.dart:202 Uncaught Error: Assertion failed: file:///Users/brettmorgan/Documents/GitHub/dart-services/flutter-sdk/packages/flutter/lib/src/widgets/framework.dart:2577:20
_debugCurrentBuildTarget == context
is not true
    at Object.throw_ [as throw] (errors.dart:251)
    at Object.assertFailed (errors.dart:29)
    at framework.dart:2577
    at framework.BuildOwner.new.buildScope (framework.dart:2580)
    at RenderObjectToWidgetAdapter.new.attachToRenderTree (binding.dart:1111)
    at binding$.WidgetsFlutterBinding.new.attachRootWidget (binding.dart:943)
    at binding.dart:924
    at internalCallback (isolate_helper.dart:48)

See #1966 for steps to reproduce

@johnpryan johnpryan added type-enhancement A request for a change that isn't a bug area-error-messaging labels Jan 27, 2022
@domesticmouse
Copy link
Member

@srawlins Any ideas on if this is even possible?

@domesticmouse domesticmouse added area-dart-services P3 A lower priority bug or feature request labels Jan 27, 2022
@srawlins
Copy link
Member

srawlins commented Feb 2, 2022

When compiling DDC on the dev's workstation, we could first cd to a temp directory with a known suffix (say _foo/), then remove that text from errors (s#file:///.*_foo/##).

@johnpryan
Copy link
Contributor Author

Related to #1365

@johnpryan johnpryan reopened this Oct 6, 2022
@parlough
Copy link
Member

parlough commented Jun 17, 2024

This potentially is not as relevant now as the deploy is happening on Cloud Build, but it's still potentially worth investigating.

I'm going to consolidate this issue in to #3008 alongside other exception surfacing changes. Thanks for the report!

@parlough parlough closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
@parlough parlough added the closed-duplicate Closed in favor of an existing report label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dart-services area-error-messaging closed-duplicate Closed in favor of an existing report P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants