-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support @docImports #3798
Labels
P2
A bug or feature request we're likely to work on
type-enhancement
A request for a change that isn't a bug
Comments
srawlins
added
type-enhancement
A request for a change that isn't a bug
P2
A bug or feature request we're likely to work on
labels
Jun 26, 2024
1 task
srawlins
added a commit
that referenced
this issue
Jun 26, 2024
This is work towards #3798. The analyzer is now tagging Comment nodes with references with various static elements, all backed by the new @docImport syntax, via a new DocImportScope (see https://dart-review.googlesource.com/c/sdk/+/345361 and https://dart-review.googlesource.com/c/sdk/+/353232). But they're not available in the element model. So while we have the syntax nodes, in PackageGraph, we must "side-car" the data, by storing it in separate classes (with no references to any AST nodes). So in this change we introduce the CommentReferenceData class, attach instances to ModelNode.
Maybe worth mentioning here or a separate bug: Sometimes /// <!--
/// @docImport 'library.dart';
/// -->
library; |
Ooh that "sometimes" would be good to know. |
The next time I have to do it, you'll be the first to know :)
Looks like it happened here: And here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P2
A bug or feature request we're likely to work on
type-enhancement
A request for a change that isn't a bug
There is much work to do, and this is more of an umbrella ticket.
@docImport
syntax. Introduce a syntax for importing elements just for doc comment references sdk#50702The text was updated successfully, but these errors were encountered: