Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native_assets_cli] Remove dry-run #1485

Open
dcharkes opened this issue Aug 30, 2024 · 0 comments
Open

[native_assets_cli] Remove dry-run #1485

dcharkes opened this issue Aug 30, 2024 · 0 comments
Assignees
@dcharkes
Labels
package:native_assets_cli
Milestone
Native Assets v1.0

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented Aug 30, 2024 •
edited
Loading

Dry run is removed from Flutter in master. Dart 3.7 needs to be released before we can remove it in the packages here.

Getting rid of dry run would simplify the abstractions for our users.

Getting rid of dry run requires: [...]

The requirements have been fulfilled, we should remove dry run from Flutter.
@dcharkes dcharkes added this to the Native Assets v1.0 milestone Aug 30, 2024
@dcharkes dcharkes mentioned this issue Aug 30, 2024
Closed
@dcharkes dcharkes self-assigned this Aug 30, 2024
@dcharkes dcharkes mentioned this issue Aug 30, 2024
Closed
@dcharkes dcharkes moved this to In Progress in Native Assets Aug 30, 2024
@dcharkes dcharkes removed the status in Native Assets Sep 13, 2024
@dcharkes dcharkes moved this to In Progress in Native Assets Nov 22, 2024
@dcharkes dcharkes mentioned this issue Nov 27, 2024
Merged
auto-submit bot pushed a commit that referenced this issue Nov 27, 2024
@dcharkes
[native_x] Deprecate dryRun (#1757)
9ec7403 
This deprecates `BuildConfig.dryRun`.

We will be able to remove it after Dart 3.7 is released and we can increase the SDK bound in `native_assets_cli` to that version.

For now, add some ignores to suppress to suppress the deprecation lints.

Bug:

* #1485
@dcharkes dcharkes mentioned this issue Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcharkes dcharkes

Labels
package:native_assets_cli
Projects
Native Assets
Status: In Progress
Milestone
Native Assets v1.0
Development

No branches or pull requests
1 participant
@dcharkes