Skip to content

Symlinks are ignored when publishing to a hosted pub repository #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxwellpeterson-wf opened this issue Mar 31, 2016 · 4 comments
Closed
Labels
type-enhancement A request for a change that isn't a bug

Comments

@maxwellpeterson-wf
Copy link

We have a package that supplies most of our common frontend styling - SASS, CSS, icons, fonts, etc.

This repository existed long before we started using Dart, so most of the code is in top-level directories like sass/ and dist/. When using the package as a github dependency we were able to symlink some the necessary directories into lib/. These symlinks persist upon download/git clone, and everything works great.

However, when we publish the package to our new hosted private pub repository, the symlinks do not make it into the tar archive which means we get a mostly empty lib/ directory and cannot use our static assets.

It seems as though an option could be used with the tar command to include the symlinks before uploading it to the pub repository server.

@nex3 @trentgrover-wf @greglittlefield-wf

@aaronlademann-wf
Copy link

For reference, our new hosted private pub repository - as a result of #1335 being closed.

@nex3
Copy link
Member

nex3 commented Mar 31, 2016

I'm fine with passing an option to tar to fold in symlinks. Can you folks figure out how to do so in a cross-platform way? GNU tar often has different options than the BSD tar that Mac OS uses, and on Windows we use 7zip which is entirely different.

@nex3 nex3 added type-enhancement A request for a change that isn't a bug needs-info Additional information needed from the issue author labels Mar 31, 2016
@greglittlefield-wf
Copy link
Contributor

Just tested the latest 7zip on Windows, and it looks like it follows symlinks the way we want, by default! This issue likely only exists on non-Windows systems.

Looks like OS X's BSD tar also supports the same -h "dereferencing" flag that @maxwellpeterson-wf linked to in GNU tar, so that seems like a viable approach.

@nex3 nex3 removed the needs-info Additional information needed from the issue author label Apr 5, 2016
@nex3 nex3 closed this as completed in be164a8 Apr 5, 2016
@aaronlademann-wf
Copy link

Thanks for the fix @nex3 !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants