Add option to use rules from .gitignore even if .pubignore present #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4545.
When a .pubignore is present, it is read. If it starts with, on an independent line, the phrase:
(ignoring whitespace), then rules from gitignore are also considered.
I've not added tests, and the issue hasn't been discussed - maybe it's not such a good idea as it's adding some complexity to a simple format (and it doesn't exist in the gitignore 'spec'), or maybe it's not adding enough complexity (maybe the user should be required to state the path to a file). I'm not sure how else such a feature could be implemented, however.
But since it's an easy change to make, it's not a waste of time if not accepted. I can add tests if needed, but might need some guidance on how best to do it.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.