-
Notifications
You must be signed in to change notification settings - Fork 19
Implement sync get() #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement sync get() #590
Conversation
Update:
|
Update:
|
I can't push to your branch, but this patch: diff --git a/src/dask_awkward/lib/core.py b/src/dask_awkward/lib/core.py
index 4139b2e..ed1714b 100644
--- a/src/dask_awkward/lib/core.py
+++ b/src/dask_awkward/lib/core.py
@@ -1815,7 +1815,7 @@ def compute_typetracer(dsk: HighLevelGraph, name: str) -> ak.Array:
return typetracer_array(
Delayed(
key,
- dsk.cull({key}),
+ dsk.cull_layers({name}),
layer=name,
).compute()
) brings it further down to:
|
I changed it locally and it didn't seem to make any difference to me? I notice that the CI run "conda Tests / pytest (macos-latest, 3.11)" also shows only 8 failures, so perhaps my environment isn't quite right. Strange that you can't push to this branch - is there some permission I can give? I do have "Maintainers are allowed to edit this pull request" set. |
I'll try a fresh setup soon for me, I'm sure I'm doing something wrong here... |
with latest (reports 9 failed in CI) |
The ramaining problem is recursion: the arguments are not being followed all the way down or classic-task-like (func, arg, arg, ...) not getting called. Probably, _get_sync and _unwind should be one recursive function, but I can't quite phrase it right. |
@pfackeldey : as stands, pytest runs on my system and master dask, with